initialize genesis data asap at node start #15470
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasey
force-pushed
the
init-genesis-asap
branch
2 times, most recently
from
8930b46 to
89386b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This PR initializes a package-level value that makes the genesis state, validators root and time available to other components as package level functions:
genesis.State(),genesis.ValidatorsRoot(),genesis.Time(). By ensuring that these values are always easily available we can simplify a lot of code that requires complicated dependency injection, and remove tech debt likestartup.Clock. Many pieces of code also have complex initialization logic to wait until the values are available (egstartup.ClockWaiter, one of my most shameful contributions to prysm).Other notes for review
When reordering node initialization I noticed that clearDB had gotten out of control and made init more complicated, so I added a new type to manage handling the db clearing flags.
Acknowledgements