refactor: removing redundant codes in htrutils.go
#15453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syjn99
commented
Jun 28, 2025
| @@ -219,7 +219,7 @@ func TestWithdrawalRoot(t *testing.T) { | |||
| }{ | |||
| { | |||
| name: "nil", | |||
| input: &enginev1.Withdrawal{}, | |||
There was a problem hiding this comment.
It was actually not nil as the pointer is passed.
|
After finding issue #15398, it looks like major changes to SSZ usage are upcoming. I'm wondering if my work will still be meaningful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Refactor
What does this PR do? Why is it needed?
While I'm exploring
encodingpackage, I found thatencoding/ssz/htrutils.gohad some redundant codes though we're using auto-generated SSZ codes byfastssz. This PR refactors by removing those codes.Other notes for review
b85509d adds a type alias to satisfy
Hashablein interface for each transaction as bytes. Feedbacks are welcomed as the type alias often causes a bad readability.Acknowledgements