generic ssz list encoding #15447
Open
generic ssz list encoding #15447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasey
force-pushed
the
generic-list-serdes
branch
from
4393d4d to
1d25da2
Compare
Co-authored-by: Bastin <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
We have written a few ssz list encoders by hand. Decoding such a list has many edge cases and error conditions, which a generic implementation can handle in a consistent way.
Which issues(s) does this PR fix?
Other notes for review
Because of the annoying quirks of go generics using interface constraints, we have to pass in a callback to create values of
T(or do interface assertions on anany, which is worse). For the existing rpc request types we already have listtype Things []Thingstyle definitions with ssz methodsets, which seem natural for encapsulating those details. I think it could be nice to add another type tolist.gowhich holds a constructor func and pair of un/marshal methods, that can be stored in a package var, so that calling these methods can still be concise without the custom type + methodset boilerplate.Acknowledgements