switching enable to disable for duties v2 #15445
Open
+25
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
a followup on #15380
enable-duties-v2todisable-duties-v2to default to using duties v2.performance comparison
get duties
get duties v2
More metrics snapshots have been taken but stored on notion.
it seems like in the happy case the times are about the same ( this is strange as I thought the committee list being serialized and unserialized would have caused a more consistent time different)
in other cases it seems like the get duties v2 does save a little bit of time from 100-400ms through not having to have the committee list and removing rechecks on validators not found in the state.
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements