fix: restore resolv.conf for armbian/ubuntu images #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foosel
requested changes
Mar 3, 2025
| # workaround for Armbian > 24.5, because it uses a symlink for /etc/resolv.conf | ||
| if [ -h /etc/resolv.conf ]; then | ||
| link_target="$(readlink /etc/resolv.conf.orig)" | ||
| echo "${link_target}" > /etc/resolv.conf.link |
There was a problem hiding this comment.
Shouldn't this be /etc/resolv.conf? The orig version doesn't yet exist at this point.
There was a problem hiding this comment.
yep! you're absolutely right! i must have made a mistake when copy&paste from my test branch. i fixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a routine to restore the original
/etc/resolv.confin the end_chroot_script. Because this file is a symlink in Armbian > 24.5, we have to store the absolute path of the target file instead of just moving the file.I tested it in this run: https://github.com/meteyou/MainsailOS-dev/actions/runs/13609432940/job/38044755707#step:12:4048