Skip to content

feat: 🍰 Refactor Social Media List With Slots #4773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 6, 2022
Merged

feat: 🍰 Refactor Social Media List With Slots #4773

merged 15 commits into from
May 6, 2022

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Nov 5, 2021 •
edited
Loading

🍰 Pullrequest

Refactor social media list with slots to reuse it for the organisations list.

Issues

Todo

@Tirokk Tirokk self-assigned this Nov 5, 2021
Tirokk added 8 commits November 9, 2021 10:48
@Tirokk
Implement edit callback, fist step
280f0f5
@Tirokk
Split social media page and list component
b740033 
- Rename variables.
- Implement callbacks.
- Fix tests.
@Tirokk
Cleanup
32844b8
@Tirokk
Fix and refine tests
51eca9a
@Tirokk
Correct namings etc.
7c43372 
- Rename all "link" contaning names from MySomeThingList.
- Remove comment from notificationsMiddleware.
- Create translations.
@Tirokk
Fix tests for favicon urls
d67b0c8
@Tirokk
Merge branch '4797-renew-jwt-decode-test' of github.com:Ocelot-Social…
0e7aa93 
…-Community/Ocelot-Social into 4771-refactor-social-media-list-with-slots
@Tirokk
Refactor Cypress tests for social media
0d1e8b8
@Tirokk Tirokk changed the title feat: 🍰 [WIP] Refactor Social Media List With Slots feat: 🍰 Refactor Social Media List With Slots Nov 23, 2021
@Tirokk Tirokk requested review from ulfgebhardt and Mogge November 23, 2021 10:08
@Tirokk Tirokk requested a review from ogerly April 26, 2022 11:58
ogerly
ogerly reviewed May 6, 2022
View reviewed changes
Copy link
Contributor

@ogerly ogerly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted unused css, in my new branch

@Tirokk Tirokk requested a review from ogerly May 6, 2022 09:36
@Tirokk Tirokk merged commit 1969192 into master May 6, 2022
@Tirokk Tirokk deleted the 4771-refactor-social-media-list-with-slots branch May 6, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogerly ogerly ogerly approved these changes

@ulfgebhardt ulfgebhardt Awaiting requested review from ulfgebhardt

@Mogge Mogge Awaiting requested review from Mogge

Assignees

@Tirokk Tirokk

Labels
design feature refactor service: webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔧 [Refactor] Social Media List With Slots For Reuse As Org List
2 participants
@Tirokk @ogerly