Skip to content

Generalize compute_MVBS and improve its efficiency for Dask input #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Nov 23, 2022
Merged

Generalize compute_MVBS and improve its efficiency for Dask input #878

Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
921a4d9
establish core function for binning and computing the mean of a 2D array
b-reyes Oct 11, 2022
12c0d69
finish structure of bin_and_mean_2d and create simple tests for it
b-reyes Oct 11, 2022
0141f8e
modify bin_and_mean_2d so that it produces the appropriate values and…
b-reyes Oct 18, 2022
7e230e3
investigate more efficient dask graph
b-reyes Oct 18, 2022
43eb062
investigate chunking of MVBS computation
b-reyes Oct 19, 2022
1e0c975
Merge branch 'dev' into new-comp-mvbs
b-reyes Oct 19, 2022
fd91e3a
add new approach that computes mean binned echorange values and then …
b-reyes Oct 19, 2022
9b85afb
remove commented out lines and add a function for bin and meaning the…
b-reyes Oct 20, 2022
44adc23
start creating a bin and mean 2d method that accounts for different e…
b-reyes Nov 4, 2022
a79dae4
replace previous bin and mean method with general method, construct m…
b-reyes Nov 4, 2022
2a7629a
document and clean up code associated with creating the mock data set…
b-reyes Nov 4, 2022
86a1491
allow Sv and echo_range arrays to be dask arrays in mock data
b-reyes Nov 4, 2022
49b3745
add pytest fixture to test_bin_and_mean_2d
b-reyes Nov 4, 2022
ae12a6e
begin documenting all functions needed to compute MVBS along a channel
b-reyes Nov 4, 2022
2a4afcd
finish documenting get_MVBS_along_channels function
b-reyes Nov 7, 2022
d55ef17
incorporate new bin and mean method into compute_MVBS and go back to …
b-reyes Nov 8, 2022
cc02dad
make the MVBS output values of new method be equivalent to the old me…
b-reyes Nov 8, 2022
7dadbf4
add code section that groups different echo_range values, computes th…
b-reyes Nov 8, 2022
42d18a8
add two functions (less and more comprehensive) that determine if gro…
b-reyes Nov 9, 2022
e666950
modify get_unequal_rows to account for dask input and add bool input …
b-reyes Nov 9, 2022
cc8770c
add seed to test_bin_and_mean_2d and randomly choose a ping bin to be…
b-reyes Nov 9, 2022
12686ad
remove old functions associated with compute_MVBS and use the new com…
b-reyes Nov 9, 2022
646f45c
comment and add docstrings to previously undocumented functions requi…
b-reyes Nov 10, 2022
ff095cd
clean up bin_and_mean_2d code by creating a function for grouping, bi…
b-reyes Nov 11, 2022
8268748
catch warnings associated with taking the nanmean of an array filled …
b-reyes Nov 23, 2022
7cadba2
provide more specific docstring for arr in bin_and_mean_echo_range
b-reyes Nov 23, 2022
32093d1
refactor and rename code associated with determining if grouping of e…
b-reyes Nov 23, 2022
94d640d
move all core routines needed for compute_MVBS into the python script…
b-reyes Nov 23, 2022
7b8fb36
add note to docstring of bin_and_mean_2d and rename group_bin_mean_ec…
b-reyes Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading