Skip to content

Make apply_mask function agnostic to the dimensions order. #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

NikiDab
Copy link

@NikiDab NikiDab commented May 4, 2025

Addresses issue #1402.

@NikiDab NikiDab changed the title Issue #1402: Make apply_mask function agnostic to the dimensions order. Make apply_mask function agnostic to the dimensions order. May 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.48%. Comparing base (9f56124) to head (e251969).
Report is 206 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1496      +/-   ##
==========================================
+ Coverage   83.52%   93.48%   +9.96%     
==========================================
  Files          64        3      -61     
  Lines        5686      215    -5471     
==========================================
- Hits         4749      201    -4548     
+ Misses        937       14     -923     
Flag Coverage Δ
unittests 93.48% <100.00%> (+9.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leewujung
Copy link
Member

@NikiDab : Can you add some tests to make sure the changes work as intended? Thanks.

@NikiDab
Copy link
Author

NikiDab commented May 8, 2025

@leewujung Sure, I will do that. I will take a similar approach as last time to add a code snippet for testing. Should I supply the test data too? I already have one from the previous issue I was working on; should I use that one?

@leewujung
Copy link
Member

@NikiDab : sure.

@NikiDab
Copy link
Author

NikiDab commented May 9, 2025

@leewujung: I am completing the section for testing. I need a mask to apply to the data. Could you please share some data for the mask, or do you want me to generate something myself? Thanks.

@leewujung
Copy link
Member

@NikiDab : I think for this, mocking up small datasets/datarrays will be better for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants