-
Notifications
You must be signed in to change notification settings - Fork 81
Make apply_mask function agnostic to the dimensions order. #1496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…tic to the order of dimensions.
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1496 +/- ##
==========================================
+ Coverage 83.52% 93.48% +9.96%
==========================================
Files 64 3 -61
Lines 5686 215 -5471
==========================================
- Hits 4749 201 -4548
+ Misses 937 14 -923
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@NikiDab : Can you add some tests to make sure the changes work as intended? Thanks. |
@leewujung Sure, I will do that. I will take a similar approach as last time to add a code snippet for testing. Should I supply the test data too? I already have one from the previous issue I was working on; should I use that one? |
@NikiDab : sure. |
@leewujung: I am completing the section for testing. I need a mask to apply to the data. Could you please share some data for the mask, or do you want me to generate something myself? Thanks. |
@NikiDab : I think for this, mocking up small datasets/datarrays will be better for testing. |
…c to the dimension order.
for more information, see https://pre-commit.ci
Addresses issue #1402.