-
Notifications
You must be signed in to change notification settings - Fork 81
Added support for split-beam angle computation with mixed channel beam types in complex mode #1492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added support for split-beam angle computation with mixed channel beam types in complex mode #1492
Conversation
…m types in complex mode
I couldn't figure out how to download the test data used in the existing tests, so the test file used in the unit test from this PR is a best guess. |
@beatfactor: the first command in this section will pull all the test files down, and you can stop the other services afterwards. |
@leewujung Thanks, I managed to download the data by avoiding running the compose script and I added a small script Lastly, I'm not sure about the check for dask arrays in the |
hey @leewujung, any updates here? could you re-trigger the build please? |
@beatfactor : Thanks for the reminder - I just re-triggered the tests and looks like everything runs fine. I am pretty swamped for the past weeks and hopefully will be able to look at the code changes later next week. |
@beatfactor : somehow the pre-commit.ci pushes were skipped. Could you please add the suggested changes into the code? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
===========================================
- Coverage 83.52% 23.26% -60.26%
===========================================
Files 64 72 +8
Lines 5686 6633 +947
===========================================
- Hits 4749 1543 -3206
- Misses 937 5090 +4153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ok, done. Yes, it seems that the build won't push the changes if the PR is sent from a Github organization, which it is in this case. Thanks! |
This PR adds support for computing split-beam angles in datasets where only a subset of channels have valid
beam_type
values (e.g.,beam_type = 1, 17, 49, 65, 81
). It applies specifically to CW complex data.Previously, the presence of an unsupported
beam_type
would raise aValueError
.Changes:
get_angle_complex_samples()
to process each channel individually ifbeam_type
is not uniform;beam_type
values and logs a warning instead of failing.