Skip to content

Remove deprecated preprocess subpackage [all tests ci] #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2023

Conversation

emiliom
Copy link
Collaborator

@emiliom emiliom commented Jul 20, 2023

Closes #1076

@emiliom emiliom added the design label Jul 20, 2023
@emiliom emiliom added this to the 0.8.0 milestone Jul 20, 2023
@emiliom emiliom requested a review from leewujung July 20, 2023 17:08
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #1082 (6309e44) into dev (66bef5c) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1082      +/-   ##
==========================================
+ Coverage   77.71%   77.78%   +0.07%     
==========================================
  Files          67       65       -2     
  Lines        6254     6235      -19     
==========================================
- Hits         4860     4850      -10     
+ Misses       1394     1385       -9     
Flag Coverage Δ
unittests 77.78% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
echopype/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@emiliom
Copy link
Collaborator Author

emiliom commented Jul 20, 2023

Turns out I also needed to update the API documentation page (api.rst) to fix the readthedocs error. It was still pointing to the preprocess subpackage rather than commongrid and clean.

I've also updated references to preprocess in the "Data processing" page, process.md.

Contributes to #973

@emiliom emiliom changed the title Remove deprecated preprocess subpackage Remove deprecated preprocess subpackage [all tests ci] Jul 20, 2023
@leewujung
Copy link
Member

LGTM! Feel free to merge.

@emiliom
Copy link
Collaborator Author

emiliom commented Jul 22, 2023

Thanks!

@emiliom emiliom merged commit 443dacf into OSOceanAcoustics:dev Jul 22, 2023
@emiliom emiliom deleted the rmv-preprocess branch July 22, 2023 02:29
lsetiawan pushed a commit to lsetiawan/echopype that referenced this pull request Jul 28, 2023
…ics#1082)

* Remove deprecated preprocess subpackage

* docs: replace references to preprocess with clean and commongrid

* docs: add attention box about removal of preprocess subpackage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants