Transect group rename #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentina-s
approved these changes
Apr 10, 2024
echoflow/utils/file_utils.py
Outdated
| @@ -305,7 +306,7 @@ def get_zarr_list(transect_data: Union[Output, Dict], storage_options: Dict[str, | |||
|
|
|||
| return zarr_list | |||
|
|
|||
| def process_output_transects(name: str, config: Dataset, ed_list: List[Dict[str, Any]]) -> List[Output]: | |||
| def process_output_transects(name: str, config: Dataset, stage: Stage, ed_list: List[Dict[str, Any]]) -> List[Output]: | |||
There was a problem hiding this comment.
process_output_transects: do we want this to be process_output_groups?
There was a problem hiding this comment.
process_output_groups sounds good.
There was a problem hiding this comment.
Renamed Process Output Groups Function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transect renamed to group and default group. Also changed type from int to str.
@valentina-s @leewujung