g.findfile: use element aliases #5998
Open
+244
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
echoix
reviewed
Jul 2, 2025
| @@ -74,6 +75,12 @@ int main(int argc, char *argv[]) | |||
| l_flag->description = _("List available elements and exit"); | |||
| l_flag->suppress_required = YES; | |||
|
|
|||
| t_flag = G_define_flag(); | |||
| t_flag->key = 't'; | |||
| t_flag->label = _("Return code 0 when file found, 1 otherwise"); | |||
There was a problem hiding this comment.
What is the terminology, exit code or return code? Is it clear for the translators?
There was a problem hiding this comment.
Exit status and return code are the same thing, I think it would be difficult to guess what translators are more familiar with. I copied this from r.mask.status.
echoix
approved these changes
Jul 3, 2025
nilason
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
g.findfile didn't take raster/raster_3d/region, even though g.findfile -l lists them. This PR fixes that.
Also adds a new -t flag similarly to r.mask.status to get the error code without printing the results. In the future, without -t it should always return success.