lib/vector/Vlib: Fix Resource Leak Issue in dbcolumns.c #5915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
vector
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
nilason
requested changes
Jul 2, 2025
| if (db_open_database(driver, &handle) != DB_OK) | ||
| return (NULL); | ||
| if (db_open_database(driver, &handle) != DB_OK) { | ||
| goto cleanup; |
There was a problem hiding this comment.
Here we only need to shutdown driver and free fi (open database just failed!).
| @@ -74,8 +78,9 @@ const char *Vect_get_column_names(struct Map_info *Map, int field) | |||
| G_free(col_names); | |||
| G_debug(3, "%s", list); | |||
|
|
|||
| db_close_database(driver); | |||
| db_shutdown_driver(driver); | |||
| cleanup: | |||
| if (db_open_database(driver, &handle) != DB_OK) | ||
| return (NULL); | ||
| if (db_open_database(driver, &handle) != DB_OK) { | ||
| goto cleanup; |
There was a problem hiding this comment.
Here we only need to shutdown driver and free fi (open database just failed!).
| @@ -130,8 +139,9 @@ const char *Vect_get_column_types(struct Map_info *Map, int field) | |||
| G_free(sqltype_names); | |||
| G_debug(3, "%s", list); | |||
|
|
|||
| db_close_database(driver); | |||
| db_shutdown_driver(driver); | |||
| cleanup: | |||
| if (db_open_database(driver, &handle) != DB_OK) | ||
| return (NULL); | ||
| if (db_open_database(driver, &handle) != DB_OK) { | ||
| goto cleanup; |
There was a problem hiding this comment.
Same issues for Vect_get_column_names_types as for the other two function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue identified by coverity scan (CID : 1207742, 1207743, 1207745, 1207746, 1207748, 1207749)
Used
Vect_destroy_field_info( ); db_close_database_shutdown_driver( );to fix this issue.