Windows: Install MSVC runtime before using g.mkfontcap which requires it #5686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've never found a way to test by the nsis Installer whether MS runtimes are installed and if yes, which of them. that would be a smart way to inform the user why we are doing runtime installs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5663
Waiting upon a standalone installer to be generated in order to test it works as intended. The issue in #5663 was reproduced by accident by simply trying to install with the standalone installer on a Windows sandbox instance. These are disposable VMs, that contain a trimmed down version of the OS, and really has nothing in it (not even a notepad now).