ctypesgen: Add 'bool' to ctypes type map, needed for C23 #5621
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is needed for C23 support, where _Bool is not necessarily defined by default. See e.g., https://gcc.gnu.org/onlinedocs/gcc/Boolean-Type.html: > C23 added bool as the preferred name of the boolean type, but _Bool > also remains a standard keyword in the language and is supported as > such by GCC with -std=c23. GCC 15 now defaults to C23.
|
Without knowing if you'd apply it here, I copied the change over to my PR #5584 to check if it works correctly. But I'll revert it once CI done. By searching the logs in the compile step of the Windows build for "Rast_legal_semantic_label", you can know if the test in the gunittest step will fail. |
github-actions
bot
added
Python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed for C23 support, where _Bool is not necessarily defined by default.
See e.g., GCC:
GCC 15 now defaults to C23.
This patch is submitted upstream (ctypesgen/ctypesgen#225).