Skip to content

docs: adding new logo to docs #5612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 5, 2025
Merged

Conversation

cwhite911
Copy link
Contributor

I've added the new logo to the docs (See screenshot)

House keeping

We have two files grasslogo_vector.{eps|pdf} files in man directory that are used in utils/module_synopsis.sh and ps/ps.map/decorations.

Are these files still in use or can they be safely removed?

Screenshot from 2025-05-01 21-05-00

Note

This PR does not address updating the logo in the GUI. That issue is getting addressed in PR #5577

@cwhite911 cwhite911 self-assigned this May 2, 2025
@github-actions github-actions bot added the docs label May 2, 2025
@cwhite911 cwhite911 moved this from In Progress to Done in GRASS Markdown Documentation May 2, 2025
@cwhite911 cwhite911 added this to the 8.5.0 milestone May 2, 2025
@cwhite911 cwhite911 requested a review from petrasovaa May 2, 2025 01:44
@wenzeslaus
Copy link
Member

Check also the Sphinx-generated doc for Python API. That has a separate logo. I had to update that when updating the build. You should be able to check the result in the downloaded artifact if you are not building that locally.

We have two files grasslogo_vector.{eps|pdf} files in man directory that are used in utils/module_synopsis.sh and ps/ps.map/decorations.

Are these files still in use or can they be safely removed?

Good catch, but they are referenced by these two, so why to remove?

I was looking at utils/module_synopsis.sh and that looked like dead code, so perhaps you can see (let AI figure out) what it is doing and delete that in separate PR with the corresponding logo file.

ps/ps.map/decorations is not deprecated or anything, so that needs to be updated or "thoughtfully removed".

Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the module label May 2, 2025
@cwhite911
Copy link
Contributor Author

cwhite911 commented May 2, 2025

I've updated the eps and pdf versions of the logo, so they can work with PostScript.

@petrasovaa I'm going to address the logo for the python docs in another PR because I've updated them to MkDocs styling using the sphinx_material. So, this PR is good to go unless you have something else you want me to look at.

[WIP] Python Docs Styling

image

@wenzeslaus
Copy link
Member

...I've updated them to MkDocs styling using the sphinx_material. So, this PR is good to go unless you have something else you want me to look at.

That's awesome and it looks great.

@petrasovaa petrasovaa enabled auto-merge (squash) May 5, 2025 14:24
@petrasovaa petrasovaa merged commit 9e8870f into OSGeo:main May 5, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants