Skip to content

nix: Update to Python 3.12 #5550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 19, 2025
Merged

nix: Update to Python 3.12 #5550

merged 4 commits into from
May 19, 2025

Conversation

echoix
Copy link
Member

@echoix echoix commented Apr 14, 2025

My initial goal was to trigger renovate to recognize the nix packages again, as it isn't able to create a lock file update yet.
I then changed the files, run nix flake update, then ran a build.

@github-actions github-actions bot added the nix label Apr 14, 2025
@echoix
Copy link
Member Author

echoix commented Apr 17, 2025

@imincik Does this look correct?

@echoix echoix enabled auto-merge (squash) April 19, 2025 11:53
@echoix echoix disabled auto-merge May 17, 2025 20:05
@imincik
Copy link
Contributor

imincik commented May 19, 2025

@echoix Sorry, I am not sure why I constantly notice notifications from this repo too late. Please ping me over Matrix next time I am not responding.

@imincik Does this look correct?

I am not sure what exactly is the main goal of this PR.

To update to Python 3.12, it is enough to change python311Packages to python312Packages as you did. It is even better to change it to python3Packages which will point to the default Python 3 version in nixpkgs (this is what we have in nixpgks/grass package).

To update to the latest rolling version of nixpkgs (nixpkgs-unstable) you have to run nix flake update.

Also, I suggest to sync from time to time with the latest nixpgks/grass package . I can prepare a PR for that.

To wrap-up, there is nothing wrong in this PR and it can be merged as is.

@echoix echoix requested a review from neteler May 19, 2025 07:33
@echoix echoix enabled auto-merge (squash) May 19, 2025 07:33
Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks "harmless" to me, more I cannot judge.

@echoix echoix merged commit e081cb5 into OSGeo:main May 19, 2025
29 checks passed
@echoix echoix deleted the nix-flake-update branch May 19, 2025 07:43
@github-actions github-actions bot added this to the 8.5.0 milestone May 19, 2025
@imincik imincik mentioned this pull request May 19, 2025
8 tasks
@imincik
Copy link
Contributor

imincik commented May 19, 2025

Packaging update PR is created in #5671 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants