v.cluster: Add tests #5538
Merged
v.cluster: Add tests #5538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
vector
echoix
previously approved these changes
Apr 12, 2025
echoix
dismissed
their stale review
Just wanted to approve the CI run, not the PR yet
petrasovaa
reviewed
Apr 22, 2025
petrasovaa
reviewed
Apr 22, 2025
petrasovaa
requested changes
Apr 22, 2025
wenzeslaus
changed the title
petrasovaa
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces comprehensive testing for the v.cluster module after refining my initial approach. I've implemented robust validation for DBSCAN clustering, including parameter sensitivity tests for distance and min_points, 2D/3D handling with the -2 flag, and edge cases like minimal clusters and noise points. The tests now feature proper cleanup routines and resolve previous CI issues (like CRLF line endings)