-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init: Add timeout when locking mapset, add locking to Python API #5443
Open
wenzeslaus
wants to merge
14
commits into
OSGeo:main
Choose a base branch
from
wenzeslaus:lock-with-wait-and-timeout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the max tries, focusing on timeout
…ting clearly ends the loop, the elapsed time may be significantly higher for some timeouts given that the lock process execution takes a second to execute.
I need to fix the tests...there is no locking on Windows. Otherwise the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces two things:
Additionally, this syncs locking parameters and underlying code between CLI and Python API so both timeout and forcible removal of lock are available in Python as well. The tests are using the Python API.
Locked mapset example in CLI:
Lock in Python (also works as a context manager):
This also introduces an experimental execution of the grass.app with CLI API using
python -m grass.app
. Specifically, lock and unlock subcommands are now available and can be used for testing, fixing lock situations, and by external applications which need to persistently lock mapset without using the Python API directly.Example lock-unlock (path to Python packages needs to be setup, don't ask me why LD_LIBRARY_PATH does not need to be setup - it is needed for test of the Python API):