grass.gunittest: Handle null cases in assertRasterMinMax #5440
+33
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assertRasterMinMax currently fails with a TypeError if either the provided reference values or the actual determined range values are NULL. Update the method to handle NULL cases correctly.
github-actions
bot
added
Python
kritibirda26
changed the title
wenzeslaus
changed the title
wenzeslaus
requested changes
Mar 30, 2025
simplify boolean checks and use a standard message
wenzeslaus
requested changes
Apr 4, 2025
This reverts commit c2cb0c5.
to handle precision issues in json output.
wenzeslaus
requested changes
Apr 12, 2025
wenzeslaus
requested changes
Apr 12, 2025
raster/r.tile/testsuite/testrt.py
Outdated
| refmin=74.75374, | ||
| refmax=156.3299, | ||
| refmin=74.75373, | ||
| refmax=156.3300, | ||
| msg="tile-000-000 in degrees must be between 74.75374 and 156.3299", |
There was a problem hiding this comment.
This needs an update, but actually, deleting should be fine too. The default message will do here. Same below.
Co-authored-by: Vaclav Petras <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assertRasterMinMax currently fails with a TypeError if either the provided reference values or the actual determined range values are NULL. Update the method to handle NULL cases correctly.
Fixes #3241