Skip to content

wxGUI: Make GUI workspace part of mapset #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wenzeslaus
Copy link
Member

  • Automatically create workspace file in a mapset when GUI is notified about the change if it does not exist.
  • If workspace exists in a mapset, open it.
  • If workspace does not exists and but the previous mapset was in the same location, it keeps the open mapdisplays as before.
  • The updates to workspace are not saved automatically (in time interval, before switch, or at exit), so user needs to save the workspace (Ctrl+S) in order to keep the state.

This is a proof of concept and not meant for merging. If someone wants to pick it up, I'm more than fine with that.

- Automatically create workspace file in a mapset when GUI is notified about the change if it does not exist.
- If workspace exists in a mapset, open it.
- If workspace does not exists and but the previous mapset was in the same location, it keeps the open mapdisplays as before.
- The updates to workspace are not saved automatically (in time interval, before switch, or at exit), so user needs to save the workspace (Ctrl+S) in order to keep the state.

This is a proof of concept and not meant for merging. If someone wants to pick it up, I'm more than fine with that.
@wenzeslaus
Copy link
Member Author

A possible extension or variation of the proposed change is to explicitly support more than one workspace file directly in the mapset directory. Allows for more than one workspace per mapset, but does not require much additional logic or understanding as a separate subdirectory in the mapset directory. Here is a whiteboard after discussion with @veroandreo (green lines mark the new parts for workspaces):
IMG_20240426_121730929

@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python labels Jul 18, 2024
echoix and others added 2 commits July 18, 2024 22:48
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@echoix
Copy link
Member

echoix commented Nov 10, 2024

Solved conflict in import

@lindakarlovska
Copy link
Contributor

I'm not quite sure if it makes sense to combine mapsets and workspaces in the same place. The Data tab is really just about data, while a workspace represents the state of the GUI.
What if, instead of going in the direction of "I have a mapset and I want to see all its workspaces," we think the other way around:
"I have a workspace and I want to see its current mapset — and possibly some related info."

I’ve put the idea into a short presentation:
https://docs.google.com/presentation/d/1cPsE971Iis9WzRRwtR0OoUgZJRcVEmgNN6GjGzUCmUk/edit?usp=sharing
Please feel free to take a look and share your thoughts.

I know this is different from the direction of the current PR, but since it hasn’t been merged yet, I thought now might be a good time to step back and consider things from another perspective.

@petrasovaa
Copy link
Contributor

I'm not quite sure if it makes sense to combine mapsets and workspaces in the same place. The Data tab is really just about data, while a workspace represents the state of the GUI. What if, instead of going in the direction of "I have a mapset and I want to see all its workspaces," we think the other way around: "I have a workspace and I want to see its current mapset — and possibly some related info."

I’ve put the idea into a short presentation: https://docs.google.com/presentation/d/1cPsE971Iis9WzRRwtR0OoUgZJRcVEmgNN6GjGzUCmUk/edit?usp=sharing Please feel free to take a look and share your thoughts.

I know this is different from the direction of the current PR, but since it hasn’t been merged yet, I thought now might be a good time to step back and consider things from another perspective.

Maybe move this to GH discussion, it might get lost here.

@lindakarlovska
Copy link
Contributor

I'm not quite sure if it makes sense to combine mapsets and workspaces in the same place. The Data tab is really just about data, while a workspace represents the state of the GUI. What if, instead of going in the direction of "I have a mapset and I want to see all its workspaces," we think the other way around: "I have a workspace and I want to see its current mapset — and possibly some related info."
I’ve put the idea into a short presentation: https://docs.google.com/presentation/d/1cPsE971Iis9WzRRwtR0OoUgZJRcVEmgNN6GjGzUCmUk/edit?usp=sharing Please feel free to take a look and share your thoughts.
I know this is different from the direction of the current PR, but since it hasn’t been merged yet, I thought now might be a good time to step back and consider things from another perspective.

Maybe move this to GH discussion, it might get lost here.

I'm not quite sure if it makes sense to combine mapsets and workspaces in the same place. The Data tab is really just about data, while a workspace represents the state of the GUI. What if, instead of going in the direction of "I have a mapset and I want to see all its workspaces," we think the other way around: "I have a workspace and I want to see its current mapset — and possibly some related info."

I’ve put the idea into a short presentation: https://docs.google.com/presentation/d/1cPsE971Iis9WzRRwtR0OoUgZJRcVEmgNN6GjGzUCmUk/edit?usp=sharing Please feel free to take a look and share your thoughts.

I know this is different from the direction of the current PR, but since it hasn’t been merged yet, I thought now might be a good time to step back and consider things from another perspective.

I'm not quite sure if it makes sense to combine mapsets and workspaces in the same place. The Data tab is really just about data, while a workspace represents the state of the GUI. What if, instead of going in the direction of "I have a mapset and I want to see all its workspaces," we think the other way around: "I have a workspace and I want to see its current mapset — and possibly some related info."
I’ve put the idea into a short presentation: https://docs.google.com/presentation/d/1cPsE971Iis9WzRRwtR0OoUgZJRcVEmgNN6GjGzUCmUk/edit?usp=sharing Please feel free to take a look and share your thoughts.
I know this is different from the direction of the current PR, but since it hasn’t been merged yet, I thought now might be a good time to step back and consider things from another perspective.

Maybe move this to GH discussion, it might get lost here.

I have put it here: #5916.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI wxGUI related Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants