Changed install scripts to be consistent with new python installation method

[nedvedba]

Summary by Sourcery

Update installation scripts to consistently install Python using a new method across different dependency installation scripts

New Features:

• Added a new install_python() function in dependency installation scripts

Enhancements:

• Standardized Python installation process across multiple dependency installation scripts

Chores:

• Added Python installation check to prevent redundant installations

[sourcery-ai]

Reviewer's Guide

This pull request refactors the Python installation process by introducing a centralized shell function, install_python, within scripts/dependency_install_functions.sh. This function utilizes apt and the deadsnakes PPA to install specified Python versions, including development tools and venv, and creates a marker file to prevent re-installation. This new function is now called by various service-specific installation scripts to ensure a consistent Python setup. Dockerfiles related to dependencies were also modified.

Sequence diagram for Python installation process

sequenceDiagram
    participant CS as Calling Script
    participant IPF as install_python function
    participant APT as System Package Manager (apt)
    participant PPA as PPA (deadsnakes)

    CS->>IPF: Execute install_python
    IPF->>IPF: Check for .python_installed marker
    alt Marker not found
        IPF->>APT: apt update
        APT-->>IPF: Done
        IPF->>APT: apt install software-properties-common
        APT-->>IPF: Done
        IPF->>PPA: add-apt-repository ppa:deadsnakes/ppa
        PPA-->>IPF: Repository added
        IPF->>APT: apt update
        APT-->>IPF: Done
        IPF->>APT: apt install python${DATAFED_PYTHON_VERSION}...
        APT-->>IPF: Python installed
        IPF->>IPF: touch .python_installed marker
    end

Loading

Flow diagram for the new install_python function

graph TD
    A[Start] --> B{Python already installed? Check marker file};
    B -- Yes --> F[End];
    B -- No --> C[apt update];
    C --> D[apt install software-properties-common];
    D --> E[add-apt-repository ppa:deadsnakes/ppa];
    E --> G[apt update];
    G --> H[apt install python, python-dev, python-venv, python-distutils];
    H --> I[Create .python_installed marker file];
    I --> F;

Loading

File-Level Changes

Change	Details	Files
Introduced a centralized Python installation function.	Added a new shell function install_python. The function uses apt and the deadsnakes PPA to install a specified Python version. It installs the Python interpreter, development headers, venv, and distutils. A marker file is created to skip installation if already performed.	scripts/dependency_install_functions.sh
Updated various installation scripts to use the new Python installation method.	Added a call to the install_python function at the beginning of each script.	scripts/install_authz_dependencies.sh scripts/install_client_dependencies.sh scripts/install_core_dependencies.sh scripts/install_repo_dependencies.sh scripts/install_ws_dependencies.sh
Modified Dockerfiles related to dependencies.	Updated Dockerfiles (specific content changes not provided in the diff).	docker/Dockerfile.dependencies repository/docker/Dockerfile.gcs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[JoshuaSBrown]

Suggested change

	apt update
	"$SUDO_CMD" apt update

[JoshuaSBrown]

This SUDO piece needs to be added to all of the apt calls.

[AronPerez]

What was the motivation for using the deadsnakes PPA for Python installation rather than the default Ubuntu repositories?

[AronPerez]

🔥