Allow null values in constant collections #1375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KanishManuja-MS
added
the
Ready for review
xuzhg
approved these changes
Jan 11, 2019
| @@ -54,7 +54,7 @@ public CollectionConstantNode(IEnumerable<object> objectCollection, string liter | |||
|
|
|||
| foreach (object item in objectCollection) | |||
| { | |||
| this.collection.Add(new ConstantNode(item, item.ToString(), this.itemType)); | |||
| this.collection.Add(new ConstantNode(item, item != null ? item.ToString() : "null", this.itemType)); | |||
There was a problem hiding this comment.
May we replace the hard code "null" as other code?
xuzhg
pushed a commit
to xuzhg/odata.net
that referenced
this pull request
Feb 14, 2019
xuzhg
pushed a commit
that referenced
this pull request
Feb 14, 2019
jfshark
pushed a commit
to jfshark/odata.net
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes issue #1373 .
Description
CollectionConstantNode did not account for null values in the collection even if the item type is nullable.
Checklist (Uncheck if it is not completed)
Additional work necessary
I would like to test the nightly build against a sample WebAPI service to ensure that the filter works correctly all the way through for constant collections with null values in it.