Skip to content

Fix deltas #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 21, 2024
Merged

Fix deltas #1365

merged 12 commits into from
Dec 21, 2024

Conversation

mikepizzo
Copy link
Member

Fixes #1360

@mikepizzo mikepizzo requested a review from xuzhg December 3, 2024 17:05
@mikepizzo
Fix Writing Delta Responses
7ea756f 
-only write properties in deltaset items that have been set
-support writing additional properties for deleted entities
-nested resource sets that aren't deltasets should be written w/o @delta
-factored out ODataDeletedResourceSerializer
-support writing delta payloads w/out knowing navigation source (i.e., when serializing results from a function)
@mikepizzo
Remove DeltaFunctions test project
3760b8e
@mikepizzo
Code Clean-up.
b0505e0 
Leverage more common functionality in ODataResourceSerializer.
@mikepizzo mikepizzo marked this pull request as ready for review December 3, 2024 21:15
@mikepizzo
Apply review feedback
a50d2c7 
Change ODataDeletedResourceSerializer to derive from ODataResourceSerializer
@mikepizzo
Preserve setting of OmitODataPrefix
d9e78b8
@mikepizzo mikepizzo requested a review from xuzhg December 11, 2024 00:07
xuzhg
xuzhg previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@xuzhg xuzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave couple comments, but overall, it looks good to me except the DI related.

@mikepizzo
Support deleted resources in ODataResourceSerializer, rather than sep…
350161d 
…arate serializers

Add tests for deleted resources
@mikepizzo mikepizzo requested a review from xuzhg December 20, 2024 06:45
@mikepizzo mikepizzo merged commit a852d91 into main Dec 21, 2024
7 checks passed
@gathogojr gathogojr mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuzhg xuzhg xuzhg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address issues serializing a delta response payload from a function
2 participants
@mikepizzo @xuzhg