-
Notifications
You must be signed in to change notification settings - Fork 170
Update version to 8.2.4 #1117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version to 8.2.4 #1117
Conversation
2fbb74f
@habbes Shouldn't we be updating the library version as well? |
@habbes See previous PR for updating ODL dependency https://github.com/OData/AspNetCoreOData/pull/922/files |
Hold on, any changes needed in ASP.NET Core for ODL 7.19.0? |
@xuzhg we added index-based access of path segments to |
9235587
if only the dependency updates (ODL), and no changes at (WebAPI), we don't need to release Web API. Since customer can update the dependency at his side (at any time). For customer, no matter what he should do is to update "one" package version.
So, if no changes at Web API, I prefer to #2. That's my point. |
As mentioned, there's some API changes in ODL 7 that we want to take advantage of in WebAPI 8. Specifically, we added indexed-based access for Besides that, we have a number of updates made to the library since the last release, ranging from bug fixes, new features and perf improvements, so we should still release a new version of WebAPI: |
Once we have other updates to release, let's move on. |
We do have other updates, here's the change log again: 8.2.3...main
No, this does not apply to the current scenario. The difference here is we want to change the implementation of certain methods in WebAPI in order to get the improvements. But we cannot make those changes in WebAPI because they rely on new API changes introduced in ODL, so we need to update ODL in WebAPI first so that we can access the new API changes in WebAPI to improve the implementation. So this is not up to the customer, but up to us. |
That's what I asked "Do we have any changes at Web API side?" Supposed: The latest released Web API depends on ODL version 1.0. And We have the following class and method in ODL: public class A
{
public void B() { }
} Scenario 1Without public API changes, only change the logic in In this case, we don't need to release a new version of Web API. Since Scenario 2You add a new API to implement the new logic for public class A
{
public void B() { }
public void B2() { }
} In this case, if we want to let customer using |
Well understood. My point was to clarify that:
|
Update library version to 8.2.4 and ODL version to 7.20.0