[13.0][MIG] stock_storage_type_putaway_abc #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grindtildeath
force-pushed
the
13.0-mig-stock_storage_type_putaway_abc
branch
2 times, most recently
from
64b99ef to
b0d409a
Compare
guewen
added a commit
to guewen/wms
that referenced
this pull request
May 18, 2020
cluster picking: implement /stock_issue
62 tasks
|
@guewen Can we see to mege this one ? |
|
@grindtildeath Can you rebase? |
if product is None, then accessing the abc_storage will crash. This happens when the method is called from stock_storage_type_putaway_strategy/models/stock_storage_location_sequence.py, line 25
Allow to compute restrictions for multiple products and quants Use helper field from stock_location_children Remove dependency after merge of putaway_strategy into storage_type pre-commit + setup tools
* multiple assignment would use the same record for a_locations, b_locations and c_locations -> no sorting performed * if product is an empty recordset, it has no abc_storage -> a useless sorting is performed * the union operator on recordsets is not very efficient -> prefer list.append and browse the result
We will never do a put-away in an intermediate location, so they should never be kept as candidate locations for the put-away. Follow the change in OCA#12
grindtildeath
force-pushed
the
13.0-mig-stock_storage_type_putaway_abc
branch
from
97e385f to
b2e8d4c
Compare
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
OCA-git-bot
added a commit
that referenced
this pull request
Aug 27, 2020
|
It looks like something changed on |
|
Congratulations, your PR was merged at 3aa9db4. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: