[16.0] [MIG] sale_timesheet_project_manual

[FrancoMaxime]

No description provided.

[rousseldenis]

/ocabot migration sale_timesheet_project_manual

[baimont]

Code review - LGTM

[dsolanki-initos]

Functional review LGTM.

[rafaelbn]

/ocabot migration sale_timesheet_project_manual

[rafaelbn]

/ocabot rebase

[OCA-git-bot]

@rafaelbn The rebase process failed, because command git push --force acsone tmp-pr-2555:16.0-mig-sale_timesheet_project_manual failed with output:

remote: Permission to acsone/sale-workflow.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/acsone/sale-workflow/': The requested URL returned error: 403

[rafaelbn]

Trying that runbot works!

[FrancoMaxime]

@rafaelbn Hi,

I made a rebase, i hope that will trigger a new runboat

[rousseldenis]

@FrancoMaxime Could you rebase ?

[rousseldenis]

@FrancoMaxime

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[ivs-cetmix]

Hi @FrancoMaxime , thank you for your contribution! Please check the migration checklist and squash administrative commits (if any) with the previous commit for reducing commit noise

[rousseldenis]

@ivs-cetmix I don't see administrative commits that should be squashed. Moreover, this is not mandatory before merge. Please update your review

[ivs-cetmix]

@rousseldenis here it is. And because this step is listed in the "Tasks to do in the migration" it's reasonable to consider it to be a mandatory one.

[rousseldenis]

@rousseldenis here it is. And because this step is listed in the "Tasks to do in the migration" it's reasonable to consider it to be a mandatory one.

I never block migration for that reason. As IMHO, that changes the original commit stack.

[ivs-cetmix]

I never block migration for that reason. As IMHO, that changes the original commit stack.

@rousseldenis those are the migration requirements and they must be followed. You can open a discussion in the maintainer-tools if you think this should be changed.

[rousseldenis]

I never block migration for that reason. As IMHO, that changes the original commit stack.

@rousseldenis those are the migration requirements and they must be followed. You can open a discussion in the maintainer-tools if you think this should be changed.

@ivs-cetmix I did. OCA/maintainer-tools#657