Skip to content

Principle #8 documentation - automated validation #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beckyjackson opened this issue Aug 9, 2019 · 4 comments
Closed

Principle #8 documentation - automated validation #1009

beckyjackson opened this issue Aug 9, 2019 · 4 comments
Assignees
Labels
attn: Editorial WG Issues pertinent to editorial activities, such as ontology reviews and principles attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools automated validation of principles Issues for the editorial WG pertinent to the automating the validation of the Principles. principles Issues related to Foundry principles

Comments

@beckyjackson
Copy link
Contributor

FP 8 - Documentation

Automated checks:

  1. Is there a homepage for user documentation?
  2. Is there a description?
  3. Is there documentation in the ontology header?

Mechanism:

We can pull the homepage tag from the ontology YAML. This should be a valid URL that resolves (does not return HTTP status > 400). We can't guarantee that this is a documentation page, though.

There should also be a description tag in the ontology YAML. This is already checked in the metadata validation and if it is missing, the ontology gets a warning.

We can also check the ontology header for some annotations. I propose that we provide standard annotation properties to use for these that we can list on the FP page under implementation:

  • creator (dc:creator or oboInOwl:created_by?)
  • maintainer (dc:contributor or oboInOwl:saved-by?)
  • description (dc:description or maybe rdfs:comment, but that can be used for a lot of things)

We want version and license info as well, but that is checked in FP 4 and FP 1, respectively.

@beckyjackson beckyjackson added attn: Editorial WG Issues pertinent to editorial activities, such as ontology reviews and principles attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools labels Aug 9, 2019
@beckyjackson beckyjackson self-assigned this Aug 9, 2019
@cmungall cmungall added the principles Issues related to Foundry principles label Nov 22, 2019
@cmungall cmungall changed the title Principle #8 automated validation Principle #8 documentation - automated validation Nov 22, 2019
@safisher
Copy link

I wonder if there's an issue with URL redirections or timeouts. ORNASEQ is flagged as "does not resolve" but the URL is valid, although it redirects to https.

FP8 Documented: {comment: 'homepage URL (http://kim.bio.upenn.edu/software/ornaseq.shtml)
does not resolve', status: ERROR}

The dashboard is a great idea and will surely help lots of us!

@jamesaoverton
Copy link
Member

Thanks @safisher. I think you're right that we need to follow 3xx redirects.

@wdduncan wdduncan added the automated validation of principles Issues for the editorial WG pertinent to the automating the validation of the Principles. label Apr 28, 2020
@nlharris
Copy link
Contributor

I think the dashboard now does this? @matentzn?

@matentzn
Copy link
Contributor

At least for @safisher s case it works, yes! I think this can be closed. Follow up tickets should go straight to the OBO Dashboard tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attn: Editorial WG Issues pertinent to editorial activities, such as ontology reviews and principles attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools automated validation of principles Issues for the editorial WG pertinent to the automating the validation of the Principles. principles Issues related to Foundry principles
Projects
None yet
Development

No branches or pull requests

7 participants