Skip to content

Follow redirects to homepage in FP 8 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamesaoverton opened this issue Feb 25, 2020 · 5 comments · Fixed by #86
Closed

Follow redirects to homepage in FP 8 #7

jamesaoverton opened this issue Feb 25, 2020 · 5 comments · Fixed by #86
Assignees
Labels
bug Something isn't working

Comments

@jamesaoverton
Copy link
Member

@safisher points out that ORNASEQ's homepage resolves after a redirect:

OBOFoundry/OBOFoundry.github.io#1009 (comment)

@beckyjackson
Copy link
Contributor

The requests module should automatically follow redirects. Looking into this, this is an issue with the certificate.

Adding verify=False solves this, but could this be dangerous AND we get an InsecureRequestWarning.

We could do certificate verification: https://urllib3.readthedocs.io/en/latest/user-guide.html#ssl
But I suspect we'd get an SSLError here.

@jamesaoverton
Copy link
Member Author

Thanks @beckyjackson. What's the specific problem with the certificate?

@beckyjackson
Copy link
Contributor

Here's the exception message:

HTTPSConnectionPool(host='kim.bio.upenn.edu', port=443): Max retries exceeded with url: /software/ornaseq.shtml (Caused by SSLError(SSLError("bad handshake: Error([('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')])")))

It passes with verify=False, but then I get the warning:

InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings

@jamesaoverton
Copy link
Member Author

Thanks again @beckyjackson. It's weird that I don't see similar problems using other tools, such as cURL and Safari.

@matentzn
Copy link
Contributor

@anitacaron during your next Dashboard revision, can you prioritise this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants