Skip to content

Principle #11 authority - automated validation #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
beckyjackson opened this issue Aug 9, 2019 · 0 comments
Open

Principle #11 authority - automated validation #1007

beckyjackson opened this issue Aug 9, 2019 · 0 comments
Labels
attn: Editorial WG Issues pertinent to editorial activities, such as ontology reviews and principles attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools automated validation of principles Issues for the editorial WG pertinent to the automating the validation of the Principles. principles Issues related to Foundry principles

Comments

@beckyjackson
Copy link
Contributor

FP 11 - Locus of Authority

Automated checks:

  1. Does the contact have a name as label?
  2. Does the contact have an email?
  3. Does the contact have a GitHub?

Mechanism:

Checks 1 and 2 are already implemented in the metadata validation that runs across all ontology md files. If the label or email are missing from the contact tag, the check will fail. Additionally, the email must be an actual email address. Currently, github is not a required property.

As we get more github values in the contact field, we should consider moving github to a required field. I propose to move missing github properties to a warning (it can later be changed to be an error).
@beckyjackson beckyjackson added attn: Editorial WG Issues pertinent to editorial activities, such as ontology reviews and principles attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools labels Aug 9, 2019
@beckyjackson beckyjackson self-assigned this Aug 9, 2019
@beckyjackson beckyjackson mentioned this issue Oct 22, 2019
Merged
@jamesaoverton jamesaoverton mentioned this issue Nov 19, 2019
Closed
@cmungall cmungall added the principles Issues related to Foundry principles label Nov 22, 2019
@cmungall cmungall changed the title Principle #11 automated validation Principle #11 authority - automated validation Nov 22, 2019
cmungall added a commit that referenced this issue Mar 17, 2020
@cmungall
Removing mention of 2ary 3ary contacts
2acd211 
This text makes no sense as we only allow a single contact, see #1007 and http://obofoundry.org/principles/checks/fp_011
@cmungall cmungall mentioned this issue Mar 17, 2020
Merged
@wdduncan wdduncan added the automated validation of principles Issues for the editorial WG pertinent to the automating the validation of the Principles. label Apr 28, 2020
@beckyjackson beckyjackson removed their assignment May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
attn: Editorial WG Issues pertinent to editorial activities, such as ontology reviews and principles attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools automated validation of principles Issues for the editorial WG pertinent to the automating the validation of the Principles. principles Issues related to Foundry principles
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cmungall @wdduncan @beckyjackson