operator; align labels/annotations with deployment templates #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolug
added
kind/enhancement
Operator updates metadata labels and annotations (including spec.template) for proxy daemonset, stateless-lb deployment, nsp statefulset, and ipam statefulset workloads according to their deployment templates. While for nsp service and ipam service their metadata labels and annotations are updated. The update merges the existing labels and annotations with the ones found in the deployment templates so that values from templates overwrite existing entries. Labels and annotations not found in templates are left intact.
zolug
force-pushed
the
operator-update-labels-annotations
branch
from
0257a58 to
e1bbd25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Operator updates metadata labels and annotations (including spec.template) for proxy daemonset, stateless-lb deployment, nsp statefulset, and ipam statefulset workloads according to their deployment templates.
While for nsp service and ipam service their metadata labels and annotations are updated.
The update merges the existing labels and annotations with the ones found in the deployment templates so that values from templates overwrite existing entries. Labels and annotations not found in templates are left intact.
Note:
With the changes introduced by this PR, in case spec.template labels or annotations have to be aligned in accordance with the new deployment templates, then it will result in workload update even if there were no other changes.
Issue link
NA
Checklist