Skip to content

Add pyproject.toml for Custom Node Registry #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haohaocreates
Copy link

@haohaocreates haohaocreates commented May 22, 2024

We are working with dr.lt.data and comfyanon to build a global registry for custom nodes (similar to PyPI). Eventually, the registry will be used as a backend for the UI-manager. All nodes go through a verification process before being published to users.

The main benefits are that authors can

  • publish nodes by version and users can safely update nodes knowing ahead of time if their workflows will break or not
  • automate testing against new commits in the comfy repo and existing workflows through our CI/CD dashboard

Action Required:

  • Go to the registry. Login and create a publisher id. Add the publisher id into the pyproject.toml file.
  • Write a short description.
  • Merge the separate Github Actions PR and run the workflow.

If you want to publish the node manually, install the cli and run comfy node publish

Check out our docs if you want to know more about the registry. Otherwise, feel free to message me on discord at haohao_81202 or join our server if you have any questions!

@haohaocreates
Copy link
Author

hey @Nlar, wanted to send a small nudge and ask if you had any questions!

@haohaocreates
Copy link
Author

@Nlar, wondering if there's any way we can support you on this PR!

@Nlar Nlar added the enhancement New feature or request label Jun 30, 2024
@Nlar
Copy link
Owner

Nlar commented Jun 30, 2024

If the repository had a way to clearly show the required cuda version I would go ahead. Ideally, if the text could be similar to the checks for compatibility between nodes for stating requirements. My concern is that users will download the node, have it crash and then uninstall the node. Yes, RTM should be absolute, but I would prefer that the requirements be highlighted rather than give a poor impression to those under time constraints.

@haohaocreates
Copy link
Author

Hey @Nlar ! These are great points to flag, I just touched base with Data and these are some of his thoughts:

- I believe it is necessary to provide users with clear feedback regarding some key dependencies.

- Currently, ComfyUI-Manager has minimal safeguards to prevent the reinstallation of ComfyUI core dependencies from custom nodes. However, I believe it is also necessary to provide information about important packages such as diffusers.

- Additionally, I believe it is necessary to manage frequently reported package conflicts proactively.

- I would like the CNR API to provide information about such potential conflicts.

- In cases of such conflicts, it would be better to proceed by getting confirmation from the user before installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants