fontforge: remove unused uthash dependency #422906
Merged
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordGrimmauld
added
6.topic: closure size
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
|
Needs to target staging; LGTM. |
Upstream removed the uthash dependency in 2019 [1]. It us unnecessary to add this dependency in nixpkgs, and just unnecessarily bloats closure size. [1] fontforge/fontforge@1ec6231
LordGrimmauld
force-pushed
the
fontforge-uthash
branch
from
a2d1dce to
afade4d
Compare
|
done |
philiptaron
approved these changes
Jul 6, 2025
ofborg
bot
added
the
2.status: merge conflict
|
@wolfgangwalther take a look at this ofBorg label addition! |
ofborg
bot
removed
the
2.status: merge conflict
|
Odd. I knew that ofborg would remove the merge conflict label, but not that it would add it, too. And wrongly so. I guess we can remove this code from ofborg now, WDYT? |
nixpkgs-ci
bot
added
12.approvals: 1
|
I suspect i know what happened.
|
That was my takeaway. Labeling is now the exclusive purview of the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream removed the uthash dependency in 2019 [1]. It us unnecessary to add this dependency in nixpkgs, and just unnecessarily bloats closure size.
Output stayed the same apart from nix store hashes, checked using
diffoscope.[1] fontforge/fontforge@1ec6231
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.