Skip to content

python310/python311: fix failing tests with openssl >= 3.4 #382794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

lblasc
Copy link
Contributor

@lblasc lblasc commented Feb 17, 2025

Backport fix from upstream to resolve failing test of python311Packages.trio and some other packages as well.

see: python/cpython#127361

 > ----------------------------- Captured stdout call -----------------------------
       > ssl_echo_serve_sync got unexpected error: [SYS] unknown error (_ssl.c:2706)
       > =========================== short test summary info ============================
       > FAILED src/trio/_tests/test_ssl.py::test_ssl_client_basics[tls13] - ExceptionGroup: Exceptions from Trio nursery (1 sub-exception)
       > FAILED src/trio/_tests/test_ssl.py::test_checkpoints[tls13] - ExceptionGroup: Exceptions from Trio nursery (1 sub-exception)
       > FAILED src/trio/_tests/test_ssl.py::test_send_all_empty_string[tls13] - ExceptionGroup: Exceptions from Trio nursery (1 sub-exception)
       > FAILED src/trio/_tests/test_ssl.py::test_ssl_client_basics[tls12] - ExceptionGroup: Exceptions from Trio nursery (1 sub-exception)
       > FAILED src/trio/_tests/test_ssl.py::test_full_duplex_basics[tls12] - ExceptionGroup: Exceptions from Trio nursery (1 sub-exception)
       > FAILED src/trio/_tests/test_ssl.py::test_checkpoints[tls12] - ExceptionGroup: Exceptions from Trio nursery (1 sub-exception)
       > FAILED src/trio/_tests/test_ssl.py::test_send_all_empty_string[tls12] - ExceptionGroup: Exceptions from Trio nursery (1 sub-exception)
       > ===== 7 failed, 733 passed, 38 skipped, 47 deselected, 2 xfailed in 5.34s ======

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lblasc lblasc force-pushed the python311-failing-tests branch from d341693 to 28ad38e Compare February 17, 2025 14:36
@mweinelt mweinelt self-assigned this Feb 17, 2025
@mweinelt
Copy link
Member

We need a seaprate patch ported to 3.10 as well.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 18, 2025
@lblasc lblasc force-pushed the python311-failing-tests branch from 28ad38e to 964b572 Compare February 18, 2025 21:32
@lblasc lblasc changed the title python311: fix failing tests with openssl >= 3.4 python310/python311: fix failing tests with openssl >= 3.4 Feb 18, 2025
@lblasc
Copy link
Contributor Author

lblasc commented Feb 18, 2025

Pushed the patch for 3.10

] ++ optionals (pythonAtLeast "3.11" && pythonOlder "3.12") [
(fetchpatch {
url = "https://github.com/python/cpython/commit/f4b31edf2d9d72878dab1f66a36913b5bcc848ec.patch";
sha256 = "sha256-w7zZMp0yqyi4h5oG8sK4z9BwNEkqg4Ar+en3nlWcxh0=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sha256 = "sha256-w7zZMp0yqyi4h5oG8sK4z9BwNEkqg4Ar+en3nlWcxh0=";
hash = "sha256-w7zZMp0yqyi4h5oG8sK4z9BwNEkqg4Ar+en3nlWcxh0=";

@mweinelt mweinelt merged commit 5cf26c9 into NixOS:staging-next Feb 19, 2025
33 of 35 checks passed
@lblasc lblasc deleted the python311-failing-tests branch February 19, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants