Skip to content

gitui: refactor, add passthru.updateScript, 0.26.3 -> 0.27.0 #373583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 17, 2025
Merged

gitui: refactor, add passthru.updateScript, 0.26.3 -> 0.27.0 #373583

merged 3 commits into from
Jan 17, 2025

Conversation

DontEatOreo
Copy link
Member

Breaking Changes

Changelog: https://github.com/extrawurst/gitui/releases/tag/v0.27.0-rc.1
Diff: gitui-org/gitui@v0.26.3...v0.27.0-rc.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested review from mfrw, yanganto and Br1ght0ne January 13, 2025 23:25
@DontEatOreo DontEatOreo changed the title gitui: refactor, add passthru.updateScript, 0.26.3 -> 0.27.0-rc.1 gitui: refactor, add passthru.updateScript, 0.26.3 -> 0.27.0 Jan 15, 2025
@Gliczy
Copy link
Member

Gliczy commented Jan 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373583

x86_64-linux

❌ 1 package failed to build:
  • gitui

aarch64-linux

❌ 1 package failed to build:
  • gitui

@Gliczy
Copy link
Member

Gliczy commented Jan 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373583

x86_64-linux

✅ 1 package built:
  • gitui

aarch64-linux

✅ 1 package built:
  • gitui

Gliczy
Gliczy approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@Gliczy Gliczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 15, 2025
@sikmir
Copy link
Member

sikmir commented Jan 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373583

x86_64-darwin

✅ 1 package built:
  • gitui

Lord-Valen
Lord-Valen approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@Lord-Valen Lord-Valen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lord-Valen Lord-Valen added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 17, 2025
@sikmir sikmir merged commit 2e11575 into NixOS:master Jan 17, 2025
27 of 29 checks passed
@DontEatOreo DontEatOreo deleted the update-gitui branch January 30, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lord-Valen Lord-Valen Lord-Valen approved these changes

@Gliczy Gliczy Gliczy approved these changes

@mfrw mfrw Awaiting requested review from mfrw

@yanganto yanganto Awaiting requested review from yanganto

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@JohnRTitor JohnRTitor Awaiting requested review from JohnRTitor

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DontEatOreo @Gliczy @sikmir @Lord-Valen @wegank