Skip to content

zigbee2mqtt: 1.35.1 -> 1.35.2 #285931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Feb 3, 2024

https://github.com/Koenkk/zigbee2mqtt/releases/tag/1.35.2

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 3, 2024
@ofborg ofborg bot requested a review from sweber83 February 3, 2024 01:49
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 3, 2024
@mweinelt mweinelt merged commit e1ee205 into NixOS:master Feb 3, 2024
@mweinelt mweinelt deleted the zigbee2mqtt-1.35.2 branch February 3, 2024 02:44
@seberm
Copy link
Contributor

seberm commented Feb 6, 2024

Hello @mweinelt ,
sorry to ping you in a merged PR, but what was the reason to change the service Type to notify?

I have deployed the 1.35.2 version of zigbee2mqtt. The zigbee2mqtt.service unit is stuck in activating state and after some time it timeouts and restarts - it's actually never started.

...
Feb 06 23:01:49 hass zigbee2mqtt[5058]: Zigbee2MQTT:info  2024-02-06 23:01:49: Zigbee2MQTT started!
...
Feb 06 23:03:12 hass systemd[1]: zigbee2mqtt.service: start operation timed out. Terminating.                                                                                                                                                 
Feb 06 23:03:12 hass zigbee2mqtt[5058]: Zigbee2MQTT:info  2024-02-06 23:03:12: MQTT publish: topic 'zigbee2mqtt/bridge/state', payload 'offline'                                                                                              
Feb 06 23:03:12 hass zigbee2mqtt[5058]: Zigbee2MQTT:info  2024-02-06 23:03:12: Disconnecting from MQTT server
Feb 06 23:03:12 hass zigbee2mqtt[5058]: Zigbee2MQTT:info  2024-02-06 23:03:12: Stopping zigbee-herdsman...
Feb 06 23:03:12 hass zigbee2mqtt[5058]: Zigbee2MQTT:info  2024-02-06 23:03:12: Stopped zigbee-herdsman
Feb 06 23:03:12 hass zigbee2mqtt[5058]: Zigbee2MQTT:info  2024-02-06 23:03:12: Stopped Zigbee2MQTT
Feb 06 23:03:12 hass systemd[1]: zigbee2mqtt.service: Failed with result 'timeout'.
░░ Subject: Unit failed
░░ Defined-By: systemd
░░ Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
░░ 
░░ The unit zigbee2mqtt.service has entered the 'failed' state with result 'timeout'.
Feb 06 23:03:12 hass systemd[1]: Failed to start Zigbee2mqtt Service.
░░ Subject: A start job for unit zigbee2mqtt.service has failed
░░ Defined-By: systemd
░░ Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
░░ 
░░ A start job for unit zigbee2mqtt.service has finished with a failure.
░░ 
░░ The job identifier is 4055 and the job result is failed.
Feb 06 23:03:12 hass systemd[1]: zigbee2mqtt.service: Consumed 2.792s CPU time, 121.0M memory peak, read 0B from disk, written 40.0K to disk, received 398.2K IP traffic, sent 153.8K IP traffic.
░░ Subject: Resources consumed by unit runtime
░░ Defined-By: systemd
░░ Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
░░ 
░░ The unit zigbee2mqtt.service completed and consumed the indicated resources.

If I run the zigbee2mqtt manually under the zigbee2mqtt user, everything seems to work properly.

My current workaround is to set the service type back to simple.

systemd.services.zigbee2mqtt.serviceConfig.Type = lib.mkForce "simple";

Any hints? Should I open a new issue?

Thanks!

@mweinelt
Copy link
Member Author

mweinelt commented Feb 6, 2024

See Koenkk/zigbee2mqtt#20482

@mweinelt
Copy link
Member Author

mweinelt commented Feb 7, 2024

Reverted in #286989

@seberm
Copy link
Contributor

seberm commented Feb 7, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants