Skip to content

nixos/prometheus/exporters: adjust scaphandre assertions #240571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2023
Merged

nixos/prometheus/exporters: adjust scaphandre assertions #240571

merged 2 commits into from
Jul 4, 2023

Conversation

gaelreyrol
Copy link
Contributor

Description of changes

A few changes suggested from #239803 post merge.

I also provided an updateScript and add a testVersion on the package itself.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@gaelreyrol gaelreyrol self-assigned this Jun 29, 2023
@gaelreyrol gaelreyrol requested a review from ambroisie June 29, 2023 17:38
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 29, 2023
@gaelreyrol gaelreyrol mentioned this pull request Jun 29, 2023
Merged
12 tasks
@gaelreyrol gaelreyrol force-pushed the scaphandre-module-assertions branch from 2fff2dc to ec88371 Compare June 29, 2023 19:55
@gaelreyrol gaelreyrol marked this pull request as ready for review June 29, 2023 19:59
@gaelreyrol gaelreyrol requested a review from WilliButz as a code owner June 29, 2023 19:59
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 29, 2023
ambroisie
ambroisie approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@ambroisie ambroisie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those should be two commits, but otherwise LGTM.

@gaelreyrol gaelreyrol force-pushed the scaphandre-module-assertions branch from ec88371 to f856229 Compare June 30, 2023 13:11
@gaelreyrol
Copy link
Contributor Author

I think those should be two commits, but otherwise LGTM.

Done!

@gaelreyrol gaelreyrol requested a review from ambroisie June 30, 2023 13:11
@figsoda figsoda added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 1, 2023
@gaelreyrol
Copy link
Contributor Author

Anyone to merge this one? 🙏

@ambroisie ambroisie requested a review from drupol July 4, 2023 09:21
@ambroisie
Copy link
Contributor

Adding @drupol as a reviewer, since he was the merger of the original PR.

@drupol drupol merged commit 3ede00e into NixOS:master Jul 4, 2023
@gaelreyrol gaelreyrol deleted the scaphandre-module-assertions branch July 4, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@ambroisie ambroisie ambroisie approved these changes

@WilliButz WilliButz Awaiting requested review from WilliButz

Assignees

@gaelreyrol gaelreyrol

Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaelreyrol @ambroisie @drupol @figsoda