Skip to content

prometheus-php-fpm-exporter: init at 2.2.0 #240394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2023
Merged

prometheus-php-fpm-exporter: init at 2.2.0 #240394

merged 3 commits into from
Jun 29, 2023

Conversation

gaelreyrol
Copy link
Contributor

@gaelreyrol gaelreyrol commented Jun 28, 2023 •
edited
Loading

Description of changes

This PR adds a new package php-fpm_exporter which uses PHP-FPM status page to request usage and expose it as Prometheus metrics. It includes the new package and the new exporter in services.prometheus.exporters module.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 28, 2023
@gaelreyrol gaelreyrol force-pushed the prometheus-php-fpm-exporter-init branch from 3e4d146 to 8ab449f Compare June 28, 2023 19:02
@github-actions github-actions bot added 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Jun 28, 2023
@gaelreyrol gaelreyrol force-pushed the prometheus-php-fpm-exporter-init branch from 5ac1208 to ef775de Compare June 28, 2023 19:04
@gaelreyrol gaelreyrol self-assigned this Jun 28, 2023
@gaelreyrol gaelreyrol added the 8.has: package (new) This PR adds a new package label Jun 28, 2023
@gaelreyrol
Copy link
Contributor Author

@GrahamcOfBorg build prometheus-php-fpm-exporter

@gaelreyrol
Copy link
Contributor Author

@GrahamcOfBorg test prometheus-exporters.php-fpm

@gaelreyrol gaelreyrol marked this pull request as ready for review June 28, 2023 19:15
@gaelreyrol gaelreyrol requested a review from WilliButz as a code owner June 28, 2023 19:15
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Jun 28, 2023
drupol
drupol reviewed Jun 28, 2023
View reviewed changes
@gaelreyrol gaelreyrol force-pushed the prometheus-php-fpm-exporter-init branch from ef775de to 94620a2 Compare June 28, 2023 20:10
@gaelreyrol gaelreyrol force-pushed the prometheus-php-fpm-exporter-init branch from 94620a2 to cba0a20 Compare June 28, 2023 20:11
@gaelreyrol gaelreyrol requested a review from drupol June 28, 2023 20:12
@gaelreyrol
Copy link
Contributor Author

@GrahamcOfBorg build prometheus-php-fpm-exporter
@GrahamcOfBorg test prometheus-exporters.php-fpm

@drupol drupol merged commit 958fb96 into NixOS:master Jun 29, 2023
@gaelreyrol gaelreyrol deleted the prometheus-php-fpm-exporter-init branch June 29, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz Awaiting requested review from WilliButz

@drupol drupol Awaiting requested review from drupol

Assignees

@gaelreyrol gaelreyrol

Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaelreyrol @drupol