Build failure: nodePackages_latest.nodejs

[JohnRTitor]

Steps To Reproduce

Steps to reproduce the behavior:

1. build nodePackages_latest.nodejs from master

Build log

Build Log

┃        >   ...
┃        > ok 4059 known_issues/test-url-parse-conformance
┃        >   ---
┃        >   duration_ms: 56.50900
┃        >   ...
┃        > ok 4060 known_issues/test-vm-function-declaration-uses-define
┃        >   ---
┃        >   duration_ms: 36.65000
┃        >   ...
┃        > ok 4061 known_issues/test-vm-timeout-escape-nexttick
┃        >   ---
┃        >   duration_ms: 806.78800
┃        >   ...
┃        >
┃        > Failed tests:
┃        > out/Release/node /build/node-v23.2.0/test/parallel/test-os.js
┃        > make: *** [Makefile:558: test-ci-js] Error 1
┃        For full logs, run 'nix log /nix/store/ahgdyngidcphsmb7zn5b1lny589pyjdc-nodejs-23.2.0.drv'.

Additional context

Found it while building zed-editor on master.

Metadata

❯ nix-info -m

• system: "x86_64-linux"
• host os: Linux 6.11.7-cachyos, NixOS, 24.11 (Vicuna), 24.11.20241109.76612b1
• multi-user?: yes
• sandbox: yes
• version: nix-env (Nix) 2.24.10
• nixpkgs: /nix/store/gg86rfp39vc7chqsszk32q7995hz4943-source

Notify maintainers

@aduh95 @Ma27

---

Note for maintainers: Please tag this issue in your PR.

---

Add a 👍 reaction to issues you find important.

[aduh95]

Failed tests:
┃ > out/Release/node /build/node-v23.2.0/test/parallel/test-os.js

Could you share the output of this test?

[JohnRTitor]

Could you point me how to do that? I am not familiar with nodePackages, just got the log from the Nix build command.

[aduh95]

As it says on the output:

For full logs, run 'nix log /nix/store/ahgdyngidcphsmb7zn5b1lny589pyjdc-nodejs-23.2.0.drv'.

From there, you can search for not ok (or for the test name, but I find not ok easier to remember).

[JohnRTitor]

Got it.

not ok 2075 parallel/test-os
  ---
  duration_ms: 37.37300
  severity: fail
  exitcode: 1
  stack: |-
    node:os:317
        throw new ERR_SYSTEM_ERROR(ctx);
        ^
    
    SystemError [ERR_SYSTEM_ERROR]: A system error occurred: uv_os_setpriority returned EACCES (permission denied)
        at Object.setPriority (node:os:317:11)
        at Object.<anonymous> (/build/node-v23.2.0/test/parallel/test-os.js:87:6)
        at Module._compile (node:internal/modules/cjs/loader:1550:14)
        at Object..js (node:internal/modules/cjs/loader:1702:10)
        at Module.load (node:internal/modules/cjs/loader:1307:32)
        at Function._load (node:internal/modules/cjs/loader:1121:12)
        at TracingChannel.traceSync (node:diagnostics_channel:322:14)
        at wrapModuleLoad (node:internal/modules/cjs/loader:219:24)
        at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:170:5)
        at node:internal/main/run_main_module:36:49 {
      code: 'ERR_SYSTEM_ERROR',
      info: {
        errno: -13,
        code: 'EACCES',
        message: 'permission denied',
        syscall: 'uv_os_setpriority'
      },
      errno: [Getter/Setter],
      syscall: [Getter/Setter]
    }
    
    Node.js v23.2.0
  ...
ok 2076 parallel/test-node-output-vm
  ---
  duration_ms: 331.84100
  ...

[aduh95]

OK that's definitely interesting! Could you confirm if the test passes if you revert nodejs/node@a094a81?

[LiviaMedeiros]

Does niceness on NixOS work differently than on most Unix systems? The os.constants.priority.PRIORITY_LOW is 19, there should be no numbers higher than that, and setting priority on same or lower level should be fine.

If it's indeed different, what's the returned value of require('node:os').type() on NixOS systems?

[JohnRTitor]

OK that's definitely interesting! Could you confirm if the test passes if you revert nodejs/node@a094a81?

Well this patch does not apply. JohnRTitor@24c5cc0

[aduh95]

Well this patch does not apply. JohnRTitor@24c5cc0

Ah right, my bad, that commit didn't make it into 23.2.0.
I reckon we have this test disabled on macOS, the comment says it's sandbox related:

nixpkgs/pkgs/development/web/nodejs/nodejs.nix

Lines 312 to 314 in 4f93e62

	# Disable tests that don’t work under macOS sandbox.
	"test-macos-app-sandbox"
	"test-os"

In any case, we should probably amend the Node.js test to not fail on EACCES