Skip to content

Benchmarking wide circuits and other optimizations #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 66 commits into
base: master
Choose a base branch
from
Draft

Benchmarking wide circuits and other optimizations #399

wants to merge 66 commits into from

Conversation

ioxid
Copy link
Contributor

@ioxid ioxid commented Mar 26, 2025

No description provided.

mizabrik and others added 30 commits March 19, 2025 20:44
@mizabrik
Squashed commit of the following:
b2f522a 
commit 272766f
Author: Alexander Vasilyev <[email protected]>
Date:   Tue Mar 18 18:25:23 2025 +0800

    Valid block & transaction in opcode tests

commit 6de4c11
Author: Alexander Vasilyev <[email protected]>
Date:   Tue Mar 18 18:24:54 2025 +0800

    Fix rw circuit min rows

commit 87f177d
Author: Alexander Vasilyev <[email protected]>
Date:   Fri Mar 14 17:50:24 2025 +0800

    Fix end_transaction

commit 2fca8ff
Author: Alexander Vasilyev <[email protected]>
Date:   Thu Mar 13 18:56:22 2025 +0800

    Update opcode tests for new zkevm state

commit 012c4d5
Author: Alexander Vasilyev <[email protected]>
Date:   Thu Mar 13 15:37:52 2025 +0800

    Fix "Illegal instruction" crash on MacOS in tests

commit 061f20b
Author: e.tatuzova <[email protected]>
Date:   Thu Mar 13 11:30:02 2025 +0400

    zkevm_state and hardhat_input_generator refactored #279

commit 03b5ba4
Author: e.tatuzova <[email protected]>
Date:   Wed Mar 12 11:05:14 2025 +0400

    RETURNDATACOPY support #279

commit ad9e097
Author: e.tatuzova <[email protected]>
Date:   Tue Mar 11 17:22:14 2025 +0400

    end_call after stop fixed #279

commit 25107b5
Author: e.tatuzova <[email protected]>
Date:   Tue Mar 11 15:53:50 2025 +0400

    start_block, start_transaction, start_call basic constraints added#279

commit 1f0f8b3
Author: e.tatuzova <[email protected]>
Date:   Tue Mar 11 15:35:40 2025 +0400

    returndata rw operations supported #279

commit 7464136
Author: e.tatuzova <[email protected]>
Date:   Mon Mar 10 19:13:40 2025 +0400

    call_keccak test #279

commit 7550bcb
Merge: 79fe04a e7d62e6
Author: e.tatuzova <[email protected]>
Date:   Mon Mar 10 18:17:47 2025 +0400

    Merge branch 'master' of github.com:NilFoundation/placeholder into HEAD

commit 79fe04a
Author: e.tatuzova <[email protected]>
Date:   Mon Mar 10 18:15:11 2025 +0400

    CALLDATACOPY added #279

commit bb2cc39
Author: e.tatuzova <[email protected]>
Date:   Mon Mar 10 08:27:13 2025 +0400

    CALLDATASIZE and CALLVALUE #279

commit 0f92c6f
Author: e.tatuzova <[email protected]>
Date:   Sat Mar 8 23:35:40 2025 +0400

    Call_commit circuit finalized#279

commit 82efc1a
Merge: 841c618 6921017
Author: e.tatuzova <[email protected]>
Date:   Fri Mar 7 19:19:18 2025 +0400

    Merge with master #279

commit 841c618
Author: e.tatuzova <[email protected]>
Date:   Fri Mar 7 08:39:25 2025 +0400

    REVERT works #279

commit 2191427
Author: e.tatuzova <[email protected]>
Date:   Fri Feb 28 17:55:38 2025 +0400

    REVERT works except SLOAD, SSTORE

commit e9018c8
Author: e.tatuzova <[email protected]>
Date:   Mon Feb 24 21:22:21 2025 +0400

    SSTORE gas #279

commit 2fd6c9a
Author: e.tatuzova <[email protected]>
Date:   Mon Feb 24 13:38:38 2025 +0400

    Some updates#279

commit 0fa4c38
Merge: 665cc9c 630ee4b
Author: e.tatuzova <[email protected]>
Date:   Fri Feb 14 16:38:04 2025 +0400

    Merge with master #279

commit 665cc9c
Author: e.tatuzova <[email protected]>
Date:   Fri Feb 14 16:36:04 2025 +0400

    zkevm removed #279

commit 50b6030
Merge: eec512c 1c7e16c
Author: e.tatuzova <[email protected]>
Date:   Mon Feb 3 17:00:59 2025 +0400

    Merge branch 'master' of github.com:NilFoundation/placeholder into HEAD

commit eec512c
Author: e.tatuzova <[email protected]>
Date:   Mon Feb 3 17:00:34 2025 +0400

    Start_call, end_call opcodes added #279

commit bde6c51
Author: e.tatuzova <[email protected]>
Date:   Thu Jan 30 22:12:01 2025 +0400

    Logging beautified, new tests added #279

commit 66e1721
Merge: aaa3560 eaa1dc3
Author: e.tatuzova <[email protected]>
Date:   Tue Jan 28 12:55:41 2025 +0400

    CODECOPY #279

commit aaa3560
Author: e.tatuzova <[email protected]>
Date:   Tue Jan 28 12:54:18 2025 +0400

    CODECOPY #279

commit eaa1dc3
Merge: f9f4abc 189a634
Author: e.tatuzova <[email protected]>
Date:   Mon Jan 20 09:37:39 2025 +0400

    Merge branch 'master' of github.com:NilFoundation/placeholder into HEAD

commit f9f4abc
Author: e.tatuzova <[email protected]>
Date:   Fri Jan 17 19:01:17 2025 +0400

    Initial deployment test #279
@mizabrik
Squashed commit of the following:
2d8ee58 
commit df8c019a37948966f59421554c2f11a8ed2c68c6
Author: ayashunsky <[email protected]>
Date:   Tue Mar 18 20:35:12 2025 +0100

    degree reduction

commit b2a4025
Merge: fc9c076 272766f
Author: e.tatuzova <[email protected]>
Date:   Wed Mar 19 11:19:55 2025 +0400

    Merge branch '279-deployment-and-callx' of github.com:NilFoundation/placeholder into HEAD

commit fc9c076
Author: e.tatuzova <[email protected]>
Date:   Wed Mar 19 11:01:05 2025 +0400

    Opcode lookup to bytecode table, disable benchmarks tests

commit 8458916
Author: e.tatuzova <[email protected]>
Date:   Tue Mar 18 19:22:38 2025 +0400

    Initial implementation of wide zkevm table

commit 8649cbe
Merge: a3cc257 99f5979
Author: e.tatuzova <[email protected]>
Date:   Tue Mar 18 19:16:25 2025 +0400

    Merge branch 'wide-zkevm-circuit' of github.com:NilFoundation/placeholder into HEAD

commit 272766f
Author: Alexander Vasilyev <[email protected]>
Date:   Tue Mar 18 18:25:23 2025 +0800

    Valid block & transaction in opcode tests

commit 6de4c11
Author: Alexander Vasilyev <[email protected]>
Date:   Tue Mar 18 18:24:54 2025 +0800

    Fix rw circuit min rows

commit a3cc257
Author: e.tatuzova <[email protected]>
Date:   Fri Mar 14 16:07:46 2025 +0400

    Merge with master

commit 6c61f6c
Merge: 16f65f3 815e474
Author: e.tatuzova <[email protected]>
Date:   Fri Mar 14 15:51:11 2025 +0400

    Merge with master

commit 16f65f3
Author: e.tatuzova <[email protected]>
Date:   Fri Mar 14 15:49:23 2025 +0400

    Alchemy_input_generator_initial

commit 87f177d
Author: Alexander Vasilyev <[email protected]>
Date:   Fri Mar 14 17:50:24 2025 +0800

    Fix end_transaction

commit 2fca8ff
Author: Alexander Vasilyev <[email protected]>
Date:   Thu Mar 13 18:56:22 2025 +0800

    Update opcode tests for new zkevm state

commit 012c4d5
Author: Alexander Vasilyev <[email protected]>
Date:   Thu Mar 13 15:37:52 2025 +0800

    Fix "Illegal instruction" crash on MacOS in tests

commit 061f20b
Author: e.tatuzova <[email protected]>
Date:   Thu Mar 13 11:30:02 2025 +0400

    zkevm_state and hardhat_input_generator refactored #279

commit 03b5ba4
Author: e.tatuzova <[email protected]>
Date:   Wed Mar 12 11:05:14 2025 +0400

    RETURNDATACOPY support #279

commit ad9e097
Author: e.tatuzova <[email protected]>
Date:   Tue Mar 11 17:22:14 2025 +0400

    end_call after stop fixed #279

commit 25107b5
Author: e.tatuzova <[email protected]>
Date:   Tue Mar 11 15:53:50 2025 +0400

    start_block, start_transaction, start_call basic constraints added#279

commit 1f0f8b3
Author: e.tatuzova <[email protected]>
Date:   Tue Mar 11 15:35:40 2025 +0400

    returndata rw operations supported #279

commit 7464136
Author: e.tatuzova <[email protected]>
Date:   Mon Mar 10 19:13:40 2025 +0400

    call_keccak test #279

commit 7550bcb
Merge: 79fe04a e7d62e6
Author: e.tatuzova <[email protected]>
Date:   Mon Mar 10 18:17:47 2025 +0400

    Merge branch 'master' of github.com:NilFoundation/placeholder into HEAD

commit 79fe04a
Author: e.tatuzova <[email protected]>
Date:   Mon Mar 10 18:15:11 2025 +0400

    CALLDATACOPY added #279

commit bb2cc39
Author: e.tatuzova <[email protected]>
Date:   Mon Mar 10 08:27:13 2025 +0400

    CALLDATASIZE and CALLVALUE #279

commit 0f92c6f
Author: e.tatuzova <[email protected]>
Date:   Sat Mar 8 23:35:40 2025 +0400

    Call_commit circuit finalized#279

commit 82efc1a
Merge: 841c618 6921017
Author: e.tatuzova <[email protected]>
Date:   Fri Mar 7 19:19:18 2025 +0400

    Merge with master #279

commit 841c618
Author: e.tatuzova <[email protected]>
Date:   Fri Mar 7 08:39:25 2025 +0400

    REVERT works #279

commit 2191427
Author: e.tatuzova <[email protected]>
Date:   Fri Feb 28 17:55:38 2025 +0400

    REVERT works except SLOAD, SSTORE

commit e9018c8
Author: e.tatuzova <[email protected]>
Date:   Mon Feb 24 21:22:21 2025 +0400

    SSTORE gas #279

commit 2fd6c9a
Author: e.tatuzova <[email protected]>
Date:   Mon Feb 24 13:38:38 2025 +0400

    Some updates#279

commit 0fa4c38
Merge: 665cc9c 630ee4b
Author: e.tatuzova <[email protected]>
Date:   Fri Feb 14 16:38:04 2025 +0400

    Merge with master #279

commit 665cc9c
Author: e.tatuzova <[email protected]>
Date:   Fri Feb 14 16:36:04 2025 +0400

    zkevm removed #279

commit 50b6030
Merge: eec512c 1c7e16c
Author: e.tatuzova <[email protected]>
Date:   Mon Feb 3 17:00:59 2025 +0400

    Merge branch 'master' of github.com:NilFoundation/placeholder into HEAD

commit eec512c
Author: e.tatuzova <[email protected]>
Date:   Mon Feb 3 17:00:34 2025 +0400

    Start_call, end_call opcodes added #279

commit bde6c51
Author: e.tatuzova <[email protected]>
Date:   Thu Jan 30 22:12:01 2025 +0400

    Logging beautified, new tests added #279

commit 66e1721
Merge: aaa3560 eaa1dc3
Author: e.tatuzova <[email protected]>
Date:   Tue Jan 28 12:55:41 2025 +0400

    CODECOPY #279

commit aaa3560
Author: e.tatuzova <[email protected]>
Date:   Tue Jan 28 12:54:18 2025 +0400

    CODECOPY #279

commit eaa1dc3
Merge: f9f4abc 189a634
Author: e.tatuzova <[email protected]>
Date:   Mon Jan 20 09:37:39 2025 +0400

    Merge branch 'master' of github.com:NilFoundation/placeholder into HEAD

commit f9f4abc
Author: e.tatuzova <[email protected]>
Date:   Fri Jan 17 19:01:17 2025 +0400

    Initial deployment test #279
@mizabrik
WIP
c707404
@mizabrik
WIP: sat check passes
0d083b6
@mizabrik
Done?
986c69e
@mizabrik
Fixup
b0f5c8d
@AntoineCyr @mizabrik
rw lower constraint degree
1922c35
@mizabrik
fixup! Done?
9f6332a
@AntoineCyr @ioxid
rw small field circuit fix
6e722eb
@ioxid
fix missing include in expression.hpp
29abfbe
@ioxid
add PROFILING_ENABLED flag
c647b4b
@ioxid
nix: fix parallel_crypto3_tests config name
b59d2c6
@ioxid
fix envrc
2a31b9c
@ioxid
cmake add config for x86_64-v3
37023f6
@ioxid
dag_expression: avoid allocating nodes on stack
c0c9dc8
@ioxid
count arithmetic ops
8e3d055
@ioxid
scoped profiler improvements
cf3e20b
@ioxid
WIP benchmarking
0ac3fda
@ioxid
generate circuits
b3c25f1
@ioxid
fix gates_argument
ac1d068
@ioxid
Fix constrains
bd12134
@ioxid
Add zkevm_wide benchmarks
e36f3d9
@ioxid
Fix lookup build value map degree
26dddfe
@ioxid
multiprecision: big_uint: implement three way comparison
41832d3
@ioxid
polynomial_dfs: comparator using <=>
dc81941
@ioxid
element_fp: implement <=>
2a62563
@ioxid
implement gate argument speed-up trough packing values
692ac3c
@ioxid
fixup! implement gate argument speed-up trough packing values
45f9c96
@ioxid
Add babybear wide test
45db9df
@ioxid
do not waste time on copy constrains if there they are absent
c9175a1
ioxid and others added 30 commits March 24, 2025 21:34
@ioxid
dag: store operands indeces in small_vector to avoid allocations
60065f4
@ioxid
fix single-thread compilation on clang
72a05f3
@ioxid
add all .nix files to watch_file in envrc
c7766cc
@ioxid
simplify operator<=> implementations (also fixes compilation on gcc)
cd359ef
@ioxid
fix big_uint_manual tests
50ec8da
@ioxid
fix circuit_builder includes
d9dcedc
@ioxid
revert parts with benchmarking small fields on small rw circuit using…
c94eb18 
… logx
@ioxid
revert benchmarking test changes
d670360
@ioxid
refactor minimal_math benchmarks
8f12644
@ioxid
add develop-clang-profiling and develop-clang-release derivations
a82ca37
@ioxid
profiling improvements, add fft info
f1aac76
Stop multiplying with all rows selector in lookup argument.
1739190
@ioxid
make tests configurable through env variables
2c3eba9
@ioxid
more profiling improvements
9307252
Stop copying results when evaluating a DAG expression.
d02dae0
@Iluvmagick
Added dfs cache to lookup/gate argument.
09ea11a
@Iluvmagick
Various bugfixes.
37743dc
@Iluvmagick
Additional bugfixes.
8f0a816
@Iluvmagick
Fixed bad hash function in dag expression.
71ed264
@Iluvmagick
Fixed verification tests in nix (for real this time).
d388734
@ETatuzova
Copy lookups lower degree
0b40d4d
@ETatuzova
Lookup sat check fixed
5b8cb67
@Iluvmagick
Fixed dfs cache variable access crash.
2e2af0a
@ETatuzova
Keccak circuit multiple repetitions
9399dcc
@martun
Never multiply by the all rows selector.
40e4414
@Iluvmagick
Fixed the dfs_cache special selectors again, added tests to nix.
abf94c7
@Iluvmagick
Non-parallel FRI dfs cache integration.
d80d1ea
@ETatuzova
RW circuit constraints fixed
b333a0d
@ioxid
parallel dfs cache
aefd0b8
@ioxid
revert precommit dfs cache because it slows down FRI
3db643f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ioxid @mizabrik @AntoineCyr @Iluvmagick @ayashunsky @ETatuzova @martun