[version] Restart services on chain or protocol change #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmtrskv
force-pushed
the
restart-on-version-change
branch
from
eaed258 to
8c45672
Compare
dmtrskv
force-pushed
the
restart-on-version-change
branch
from
8c45672 to
c0bbcbc
Compare
dmtrskv
force-pushed
the
restart-on-version-change
branch
from
c0bbcbc to
f4fa6d7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors version‐related functionality to ensure that nodes and indexers correctly restart or reset their databases when the chain or protocol version changes. Key changes include:
- Extracting version‐related logic into a separate file and refactoring driver methods (adding FetchVersion and ResetDB).
- Adding a version check loop to both syncer and indexer processes.
- Refining worker task setups and logger usage across the indexer and syncer.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| nil/services/indexer/indexer.go | Refactored version checking, introduced a new logger, and updated worker task configuration. |
| nil/services/indexer/fetch_block.go | Removed unused logger variable. |
| nil/services/indexer/driver/driver.go | Removed SetupScheme; added FetchVersion and ResetDB methods. |
| nil/services/indexer/clickhouse/clickhouse.go | Refactored out SetupScheme in favor of FetchVersion and ResetDB. |
| nil/services/indexer/badger/badger.go | Removed SetupScheme and updated the IndexTxPool receiver. |
| nil/internal/collate/version.go | Added new version handling functionality for both local and remote version fetching. |
| nil/internal/collate/syncer.go | Removed duplicate version retrieval methods and integrated new version check functionality. |
| nil/internal/collate/bootstrap.go | Removed version handler logic now handled by the version package. |
| nil/common/concurrent/utils.go | Added a new RunTickerLoopWithErr function for ticker loops with error propagation. |
dmtrskv
force-pushed
the
restart-on-version-change
branch
from
f4fa6d7 to
bfcaa0b
Compare
dmtrskv
force-pushed
the
restart-on-version-change
branch
from
bfcaa0b to
384233a
Compare
dmtrskv
force-pushed
the
restart-on-version-change
branch
from
384233a to
5de1417
Compare
dmtrskv
force-pushed
the
restart-on-version-change
branch
from
5de1417 to
fe50415
Compare
dmtrskv
commented
May 9, 2025
|
|
||
| s.Run("RunArchiveNode", func() { |
There was a problem hiding this comment.
added while debugging failing tests
olegrok
reviewed
May 12, 2025
dmtrskv
force-pushed
the
restart-on-version-change
branch
from
fe50415 to
925fd7e
Compare
olegrok
approved these changes
May 16, 2025
| } | ||
|
|
||
| var res common.Hash | ||
| res, err = v.fetchGenesisBlockHash(ctx, peerId) |
There was a problem hiding this comment.
Here you can also log error
| return nil, err | ||
| } | ||
|
|
||
| if !bytes.Equal(localVersion[:], remoteVersion[:]) { |
There was a problem hiding this comment.
Isn't hashes comparable via ==/!=?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing nodes stop if the chain or protocol version changed.
Indexer stops if the chain version changed.
Changes:
Fixes #769 and #659
Tested locally: