[GH-846] AddrInfo/AddrInfoSlice reworked
#857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Un1oR
changed the title
AddrInfo/AddrInfoSlice reworked
Zerg1996
approved these changes
Apr 24, 2025
We now correctly handle multiaddresses for one peer. Both AddrInfo and AddrInfoSlice are always serialized by a flat list of all multiaddresses of all peers. During deserialization in case of AddrInfoSlice we group by PeerID.
Un1oR
force-pushed
the
bugfix/GH-846-addr-info-marshalling-fix
branch
from
001e743 to
c98d84a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
AddrInfo.Sethad a non-symmetric implementation withAddrInfo.Stringfor the case of multiple addresses at the peer, and there was no test for this.We now correctly handle multiaddresses for one peer. Both
AddrInfoandAddrInfoSliceare always serialized by a flat list of all multiaddresses of all peers. During deserialization in case ofAddrInfoSlicewe group byPeerID.