-
Notifications
You must be signed in to change notification settings - Fork 44
Per-shard-pair transaction counters #758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed4f28f
to
95f32b3
Compare
olegrok
reviewed
Apr 7, 2025
olegrok
reviewed
Apr 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Almost it looks ok. Consider my minor comments below.
dmtrskv
reviewed
Apr 7, 2025
olegrok
reviewed
Apr 7, 2025
shermike
reviewed
Apr 8, 2025
This was referenced Apr 9, 2025
shermike
reviewed
Apr 9, 2025
olegrok
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope all the suggestions from the review will be fixed in the next patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each pair of (source, destination) shards, we keep track of the number of internal transactions ever sent from source to destination, and use it to assign incremental tx ids. This allows us to prove that we have processed all the transactions from a specific shard, in order, without missing any.
In this PR, we store transaction counts in the block, as a mapping:
dstShardId ShardId -> txCount TransactionIndex
. We reuse the transaction tries (outbound and inbound) for this purpose, without storing zeroes. The transaction trie now stores two kinds of keys:TransactionIndex
(uint64) keys for transaction data;ShardId
(uint16) keys for transaction counts.We don't store zero values, so the zerostate does not have to be changed in any way.
Caveats:
TestEmptyDeployPayload
breaks other tests in its suite, even though every test works on its own. Again, I disabled the test, pending further investigation.