Support option for testing with all releases or latest release when running test workflow manually #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorder code
bendichter
approved these changes
Jun 25, 2025
ehennestad
added a commit
that referenced
this pull request
Jun 29, 2025
* Minor refactor to support dynamicprops Set * Rewrite Set to use dynamic properties * Re-add `clear` to Set * fix missing argout setting * vastly simplify Set clear * Fix NwbFile searchFor method for Sets * Undo unsupported syntax * Fix untypedSetTest - change test for construction with function input. - fix whitespace - remove validation function that displays text * Update addRawData.m Revert to use legacy syntax. Support "h5 name" over remapped "matlab-valid name", as remapped names should only be used for dot-syntax * Update addVecInd.m Remove reference to removed property of types.untyped.Set * Fix bugs in updates Set, refactor - Remove internal prefix from property names - Make properties private - Make more methods private - Reintroduce setValidationFunction (as the ValidationFunction prop is private), but make method Hidden because is it is not meant to be used by users. * Update NwbFile.m Keep use legacy syntax for Set, as the name here will refer to the h5 name * Fix failing test, add option to warn or fail if entry for set is invalid * "Standardise" error ids in types.untyped.Set * Update types.untyped.Set rename function validate -> validateEntry change error ids and message update dependent tests * Update untypedSetTest.m Update error id * Refactor constructor of types.untyped.Set Create separate function for extracting names and values for Set from varargin Skip putting names and values in "sourceMap" * Fix incomplete merge * Update Set.m Renamed isOverride to propertyAlreadyExists * Update Set/set - Renamed name to names as this can be an array - Renames val to value as this can be an array - Add validator function for values input * Update Set.m - Renamed elem to currentValue in loop for adding values to set - Fixed bug where wrong variable name was used to if property already exists - Added support for char input in mustBeSamLength validator * Update Set.m Changed header for displayNonScalarObject to be more precise * Update Set.m - Moved private methods further down in file - Update docstrings for some methods - Renamed val to value - Fixed bug where variable reference was not updated during merge - Renamed name to names in `get` where names can be an array * Update Set.m - More specific try/catch block - add method should error if value is invalid type * Fix failing test * Support running test workflow manually (#725) * Update Set.m Fix failing test. * Support option for testing with all releases or latest release when running test workflow manually (#726) * Update run_tests.yml * Update run_tests.yml Reorder code * Update untyped.rst - Updated documentation describing untyped types - Updated documentation for Sets and Anons * Update untyped.rst Updated with suggestions from chatGPT * Create NameRegistry.m * Create DynamicPropertyManager.m * Refactor Set * Update Set.m Rename variables, comments and error messages for more consistent naming * Misc cleanup * More cleanup Change wording Add check for reserved property names * Move warning to separate (internal) function and reuse across classes * Simplify getNameMappingTable method and modify some comments * Update DynamicPropertyManager.m - Updated internal class docstring - Fixed bug in class constructor, assigning input to wrong property - Updated logic in remove method - Renamed validName to propertyName in some places - Added getOriginalNameForPropertyName * Update Set.m - Updated renamed methods from PropertyManager - Added getOriginalName method - Added private method for displaying a warning that is used in two places * Update HasUnnamedGroups.m - Added arguments blocks to user-facing methods - Remove method requires original name for a set entry, will warn if original name does not exist but a property identifier does exist - Rearranged order of methods - ++ * Fix failing tests * Fixed failing test and added new tests for HasUnnamedgroups mixin * Update displayAliasWarning.m Added more detailed function description --------- Co-authored-by: Lawrence <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Added option to select whether to test with all releases or only latest release when running test workflow manually
How to test the behavior?
Checklist
fix #XXwhereXXis the issue number?