Update class generator to skip setting inherited properties in subclass constructor #721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixed a bug where the class generator adds a
obj.(propertyName) = parsedValue
for inherited properties in subclasses. The effect is that the property value is set twice, once in the superclass constructor and second in the subclass constructor. A side effect of this is that validation warnings will be shown twice when setting some properties.Example for
TimeSeries
andElectricalSeries
:Timeseries constructor:
matnwb/+types/+core/TimeSeries.m
Lines 101 to 106 in 16862b7
ElectricalSeries constructor:
matnwb/+types/+core/ElectricalSeries.m
Lines 82 to 83 in 16862b7
How to test the behavior?
Checklist
fix #XX
whereXX
is the issue number?