-
Notifications
You must be signed in to change notification settings - Fork 33
Update test workflow to run lighter testing on draft PRs #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated workflow to run tests only on latest release of MATLAB for draft PRs
Fixed json formatting bug
Cline suggested fix for error on github runner
Cline suggested fix for error on github runner
Added step for caching pip dependencies
Minor fix for failing test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
==========================================
+ Coverage 95.05% 95.08% +0.02%
==========================================
Files 161 162 +1
Lines 5868 5897 +29
==========================================
+ Hits 5578 5607 +29
Misses 290 290 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Is this to get the tests to run faster? What tests are being skipped? How long does it take to run the tests before and after the change? |
A few changes to speed things up:
No tests are skipped Sometimes testing on all releases can take more time than usual (ie if some workers are queued or for other reasons take longer to finish) last week a test run took 27 min compared to usual 12. Caching saves about 1 minute |
Does not have significant speedup gains Risk having outdated versions in cache as the cache does not detect if dependencies are updated
Based on discussion:
|
Motivation
This PR introduces a few changes to improve CI speed and efficiency:
and Python dependencies to reduce setup time.Testing across all supported MATLAB releases can occasionally take significantly longer than usual (e.g., 27 minutes vs. the typical 12), especially when workers are queued or run slower than usual. These changes aim to make draft PR iterations faster while retaining full test coverage once the PR is marked ready for review.
How to test the behavior?
Checklist
fix #XX
whereXX
is the issue number?