Skip to content

Change DataPipe shape validation to rely on maxSize instead of actual size. #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 20, 2025
Merged

Change DataPipe shape validation to rely on maxSize instead of actual size. #716

merged 9 commits into from
Jun 20, 2025

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented May 25, 2025 •
edited
Loading

Motivation

Fix #711

How to test the behavior?

Show here how to reproduce the new behavior (can be a bug fix or a new feature)

Todo:

  • Check both maxSize and actual size, and warn if actual size does not match shape constraint
  • Add unittest to specifically test DataPipe shape validation

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

ehennestad added 5 commits May 24, 2025 17:02
@ehennestad
Create validateShape.m
04f2ba5 
Added new function for validating shape of a dataset or attribute value. Extracted a static template portion from fillValidator and added a case for DataPipe values.
@ehennestad
Update validateShape.m
53cbcce
@ehennestad
Update checkDims.m
257b8c6 
Add optional argument to enforce strict check on 1D shapes, i.e not allowing shape (inf, 1) or (1, inf) etc
@ehennestad
Update fillValidators.m
d4b1c55 
Extract code "template" to another function that can be called from a validator function. The code template is static and does not need to be duplicated across many classes
@ehennestad
Regenerated classes after updating fillValidator
48d9938
@ehennestad ehennestad mentioned this pull request May 25, 2025
Merged
3 tasks
@ehennestad ehennestad changed the title Change validation of DataPipe to rely on maxSize instead of actual size Change DataPipe shape validation to rely on maxSize instead of actual size. May 29, 2025
@ehennestad
Copy link
Collaborator Author

Ideally would check both maxSize and actual size, and warn if actual size does not match shave constraint

ehennestad added 4 commits May 29, 2025 11:52
@ehennestad
Update configureDataPipeFromData.m (#717)
8c16793 
Fixed bug where maxSize should be explicitly set for DataPipe vector data
@ehennestad
Update validateShape.m
c8df4e9 
Added extra validation of actual size/shape of data pipe objects
@ehennestad
Update dataPipeTest.m
e3c2b55 
Added unit test to test new behavior
@ehennestad
Update dataPipeTest.m
e723d49 
Fixed expected warning
@bendichter bendichter marked this pull request as ready for review June 20, 2025 14:31
@ehennestad ehennestad merged commit ffbfdb2 into main Jun 20, 2025
4 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendichter bendichter bendichter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Size validation of data in TimeSeries and TimeSeries-derived classes does not work for DataPipe objects
2 participants
@ehennestad @bendichter