Skip to content

[eslint-config] resolve breaking change in eslint-plugin-package-json #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2025
Merged

[eslint-config] resolve breaking change in eslint-plugin-package-json #105

merged 2 commits into from
Mar 19, 2025

Conversation

yongholeeme
Copy link
Contributor

Related Issue

close #104

Describe your changes

handle breaking change that occurred despite a patch version update... cc JoshuaKGoldberg/eslint-plugin-package-json#957

@yongholeeme yongholeeme self-assigned this Mar 19, 2025
@npayfebot
Copy link
Contributor

npayfebot commented Mar 19, 2025 •
edited
Loading

✅ Changeset detected

Latest commit: 9a3ef5e

@naverpay/eslint-config package have detected changes.

If no version change is needed, please add skip-detect-change to the label.

The changes in this PR will be included in the next version bump.

powered by: naverpay changeset detect-add actions

@yongholeeme yongholeeme marked this pull request as ready for review March 19, 2025 03:21
@yongholeeme yongholeeme requested a review from a team as a code owner March 19, 2025 03:21
byhhh2
byhhh2 approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@byhhh2 byhhh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~ 감사합니다 👍

yceffort-naver
yceffort-naver approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exports를 지원을 안하는건가?

@yongholeeme
Copy link
Contributor Author

exports를 지원을 안하는건가?

@yceffort-naver, 넵 https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/pull/957/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

boxersb
boxersb approved these changes Mar 19, 2025
View reviewed changes
Copy link

@boxersb boxersb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yceffort-naver
Copy link
Contributor

컨벤션을 맞추려고 ... exports 를 날리다니.. ㅋㅋㅋ

@yongholeeme yongholeeme merged commit 0eeba06 into main Mar 19, 2025
3 checks passed
@yongholeeme yongholeeme deleted the feature/104_eslint-plugin-package-json branch March 19, 2025 05:27
@npayfebot npayfebot mentioned this pull request Mar 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boxersb boxersb boxersb approved these changes

@byhhh2 byhhh2 byhhh2 approved these changes

@yceffort-naver yceffort-naver yceffort-naver approved these changes

Assignees

@yongholeeme yongholeeme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[eslint-config] eslint-plugin-package-json's breaking change
5 participants
@yongholeeme @npayfebot @yceffort-naver @boxersb @byhhh2