-
Notifications
You must be signed in to change notification settings - Fork 74
fix(objectStorage): Fix invalid key format #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(objectStorage): Fix invalid key format #446
Conversation
=== RUN TestAccResourceNcloudObjectStorage_bucket_acl_basic Testings in all region / network was succeeded. |
internal/service/objectstorage/objectstorage_object_acl_test.go
Outdated
Show resolved
Hide resolved
@wonchulee 관련하여 작업 진행하고, 테스트 확인하였습니다. endpoint의 경우 추후 별도 PR로 올려두겠습니다. |
@wonchulee GetObject를 source 비교 조건문 내 else 처리로 진행하도록 하여 body를 추가하는 작업을 통일하고, 이외의 property를 모두 뒤로 빼어 명확하게 해두었습니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 수고하셨습니다!
Fixed object key parser since it did not get the value with multiple "/".
Fixed object key regex format with the same issue above.
Set endpoint with fixed value in financial environment (region "FKR" does not fit with it).
Add test code for update logic
Add Content-Type property update logic & tests at object, object_copy