Skip to content

fix(objectStorage): Fix invalid key format #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Sep 23, 2024

Conversation

Geun-Oh
Copy link
Contributor

@Geun-Oh Geun-Oh commented Sep 13, 2024

  • Fixed object key parser since it did not get the value with multiple "/".

  • Fixed object key regex format with the same issue above.

  • Set endpoint with fixed value in financial environment (region "FKR" does not fit with it).

  • Add test code for update logic

  • Add Content-Type property update logic & tests at object, object_copy

@Geun-Oh
Copy link
Contributor Author

Geun-Oh commented Sep 13, 2024

=== RUN TestAccResourceNcloudObjectStorage_bucket_acl_basic
--- PASS: TestAccResourceNcloudObjectStorage_bucket_acl_basic (17.72s)
=== RUN TestAccResourceNcloudObjectStorage_bucket_acl_update
--- PASS: TestAccResourceNcloudObjectStorage_bucket_acl_update (24.75s)
=== RUN TestAccDataSourceNcloudObjectStorage_bucket_basic
--- PASS: TestAccDataSourceNcloudObjectStorage_bucket_basic (12.87s)
=== RUN TestAccResourceNcloudObjectStorage_bucket_basic
--- PASS: TestAccResourceNcloudObjectStorage_bucket_basic (12.11s)
=== RUN TestAccResourceNcloudObjectStorage_object_acl_basic
--- PASS: TestAccResourceNcloudObjectStorage_object_acl_basic (29.71s)
=== RUN TestAccResourceNcloudObjectStorage_object_acl_update
--- PASS: TestAccResourceNcloudObjectStorage_object_acl_update (35.59s)
=== RUN TestAccResourceNcloudObjectStorage_object_copy_basic
--- PASS: TestAccResourceNcloudObjectStorage_object_copy_basic (33.41s)
=== RUN TestAccDataSourceNcloudObjectStorage_object_basic
--- PASS: TestAccDataSourceNcloudObjectStorage_object_basic (22.95s)
=== RUN TestAccResourceNcloudObjectStorage_object_basic
--- PASS: TestAccResourceNcloudObjectStorage_object_basic (22.92s)
=== RUN TestAccResourceNcloudObjectStorage_object_update
--- PASS: TestAccResourceNcloudObjectStorage_object_update (35.25s)
PASS
ok github.com/terraform-providers/terraform-provider-ncloud/internal/service/objectstorage 248.016s


Testings in all region / network was succeeded.

@Geun-Oh
Copy link
Contributor Author

Geun-Oh commented Sep 13, 2024

@wonchulee 관련하여 작업 진행하고, 테스트 확인하였습니다.

endpoint의 경우 추후 별도 PR로 올려두겠습니다.

@wonchulee wonchulee changed the title Fix/fix invalid key format fix(objectStorage): Fix invalid key format Sep 22, 2024
@Geun-Oh
Copy link
Contributor Author

Geun-Oh commented Sep 23, 2024

@wonchulee GetObject를 source 비교 조건문 내 else 처리로 진행하도록 하여 body를 추가하는 작업을 통일하고,

이외의 property를 모두 뒤로 빼어 명확하게 해두었습니다.

Copy link
Collaborator

@wonchulee wonchulee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 수고하셨습니다!

@wonchulee wonchulee merged commit 64e4747 into NaverCloudPlatform:main Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants