Skip to content

Fix Windows installer build by adding missing Arena.ofx dependency #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

acolwell
Copy link
Member

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

libheif was recently updated in MSYS2 to depend on libopenjph. This change simply adds this dependency so that the installer will build again and pass its dependency checks.

Have you tested your changes (if applicable)? If so, how?

Yes. I verified the Windows installer builds successfully again.

libheif was recently updated in MSYS2 to depend on libopenjph.
This change simply adds this dependency so that the installer will
build again and pass its dependency checks.

Signed-off-by: Aaron Colwell <[email protected]>
@rodlie
Copy link
Contributor

rodlie commented Jul 13, 2024

btw, should probably remove heif in imagemagick/arena. It serves no purpose (OIIO should handle it), don't know why it was added in the first place.

@acolwell acolwell merged commit 661ad24 into NatronGitHub:RB-2.6 Jul 13, 2024
3 checks passed
@acolwell acolwell deleted the fix_missing_arena_dep branch July 13, 2024 20:51
@acolwell
Copy link
Member Author

btw, should probably remove heif in imagemagick/arena. It serves no purpose (OIIO should handle it), don't know why it was added in the first place.

Looks like you turned it on a few years ago. c3052e9

I can try turning it back off and see what happens.

@rodlie
Copy link
Contributor

rodlie commented Jul 13, 2024

Looks like you turned it on a few years ago

Yes, that was since it was enabled on Linux/Mac at some point and I just matched the depends.

Heif might have been enabled in IM for some script usage, don't know.

I can try turning it back off and see what happens.

Nothing in openfx-arena uses or supports heif so should not break anything.

@acolwell
Copy link
Member Author

Looks like you turned it on a few years ago

Yes, that was since it was enabled on Linux/Mac at some point and I just matched the depends.

Heif might have been enabled in IM for some script usage, don't know.

I figured that was the case. I've made a change to turn it off and have started an installer build to see if anything breaks. Once that is done I'll try running Natron-Tests with that build since that test suite uses ImageMagick for image comparisons.

I can try turning it back off and see what happens.

Nothing in openfx-arena uses or supports heif so should not break anything.

Agreed. I'm always down for reducing unnecessary dependencies where possible. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants